From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B4B30341 for ; Wed, 8 Nov 2023 20:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="MZfSCdNv" Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDAD1211D for ; Wed, 8 Nov 2023 12:11:02 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-d84c24a810dso105149276.2 for ; Wed, 08 Nov 2023 12:11:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1699474262; x=1700079062; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WdQXlJuW20JcGlaQadU7ZgL5w1/h84E2psVd7Y2aHT4=; b=MZfSCdNv2PsxTeE75RiHAs/7KpUpwUrLsoi1dFjiDdIrDZhH70j9DCrJDUPEBr9IhX k7gZMoJE1XPHOhvol4wxo7YxFnOFUVUxI7qgdvUuovss16SEqcZsK0viE5E7insB/olb w2Ub/lJ8oeIEY8g2whWPsIFTchDQ2wo4Jx5VTOcRvECQdoHjLBNq2i/UrNUdBt/tLuvi ncdkEFM88s27g6Bhd6EfrJ3NhwxK9AfPzT0C1NE8B9ITcgSEup4zX1OHLwsJ6r6fWWDp VaLgVrHdENifBIUAvZtoUKQQYsi/x5aYeJhCWMpHuqbNiRms6pcmmrq5kaKKWigrfSRD e7zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699474262; x=1700079062; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WdQXlJuW20JcGlaQadU7ZgL5w1/h84E2psVd7Y2aHT4=; b=Tc7xW8cII/04j5nQevhfWfDjXdZuTtd8lVfqOhQFeOm+3hP2lTdVKIm0qn+/BY9NJT qZhbOZCnAvx5ansmytxPWxafrfwL8JWqkAdMrXV7/TY95eSMAGjBhJ333hqvpfGBzb6u FCpleYx1YzTgUWgOsienrqpIYdxwOvtZ5HpVS5TdeGRmn7XJTVelCjKV+SFz6MEO4CdQ NgwsDrCWIL9HWQfD5giCGSO56jjPeJ+JBAhNHGzrzW8MTJ9VqJFe03cnlhOZ92fqFPjy uCg6ye8fpnxXt7GMXR7bKICjQIdHwBoRTdNseJyCWKwavXoEItOYrflbZuo7QaojHJGk PY0w== X-Gm-Message-State: AOJu0YxDWoIjfgcO4VFTgQ6E1U1HwITSJnGR2Y1ioweUKmUwRnVVRect glzDTDXPivykKKszT3Trqox4D0irJdsl1FLO9Lx/ X-Google-Smtp-Source: AGHT+IGx24XRQweoz1EaCe+kSiqvIrqmyKZE1dlffO9Wgq6HodmUotEUsJYVWiUyZ7p7+YFh1nttrYhrBU0rClZtQF0= X-Received: by 2002:a25:680c:0:b0:d9c:aa29:6180 with SMTP id d12-20020a25680c000000b00d9caa296180mr2811921ybc.46.1699474262093; Wed, 08 Nov 2023 12:11:02 -0800 (PST) Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231025140205.3586473-5-mszeredi@redhat.com> <4ab327f80c4f98dffa5736a1acba3e0d.paul@paul-moore.com> <20231108-zwerge-unheil-b3f48a84038d@brauner> In-Reply-To: <20231108-zwerge-unheil-b3f48a84038d@brauner> From: Paul Moore Date: Wed, 8 Nov 2023 15:10:50 -0500 Message-ID: Subject: Re: [PATCH v4 4/6] add statmount(2) syscall To: Christian Brauner Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, Karel Zak , Ian Kent , David Howells , Linus Torvalds , Al Viro , Christian Brauner , Amir Goldstein , Matthew House , Florian Weimer , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 8, 2023 at 2:58=E2=80=AFAM Christian Brauner wrote: > > > +static int do_statmount(struct stmt_state *s) > > > +{ > > > + struct statmnt *sm =3D &s->sm; > > > + struct mount *m =3D real_mount(s->mnt); > > > + size_t copysize =3D min_t(size_t, s->bufsize, sizeof(*sm)); > > > + int err; > > > + > > > + err =3D security_sb_statfs(s->mnt->mnt_root); > > > + if (err) > > > + return err; > > > + > > > + if (!capable(CAP_SYS_ADMIN) && > > > + !is_path_reachable(m, m->mnt.mnt_root, &s->root)) > > > + return -EPERM; > > > > In order to be consistent with our typical access control ordering, > > please move the security_sb_statfs() call down to here, after the > > capability checks. > > I've moved the security_sb_statfs() calls accordingly. Okay, good. Did I miss a comment or a patch where that happened? I looked over the patchset and comments yesterday and didn't recall seeing anything about shuffling the access control checks. --=20 paul-moore.com