From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F43546434 for ; Sat, 22 Feb 2025 00:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740184454; cv=none; b=K9FPHmhT/saAjrURfo0tTknbnDcSYaCmtqT6dks1V6XwuCSke5yToC7d/+/v7pdbLEgXgIxmQyxBxCX6vK66JvjkiZWCZO6wqIrkBVAyFP96TQ32jFTuL6A3eh9HvBkBD/1faXZDtKX93ijbvp4apRbpSxo/w+KF/lKIdLvNf/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740184454; c=relaxed/simple; bh=VBQHljTSYFVCaj1bbqPfTOtZckZuFzfefk82naOnO1A=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uGmETVQwgI0JlQ5XFJJKDQB63HWlFCE3Gbfpf5Ix42Is2tz6yUq7T0NjYUeunKj95jolra6Y8LMgeEXenBUeayYzhYpdFbNKoVqi7CwNO4s1NhqOtXej488gMuMlce1pbV/thCmxLfJun50QptGU7xEeAZTY2mvYuLP+pLVpW50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=OUaLZ8oR; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="OUaLZ8oR" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-6ef60e500d7so23714457b3.0 for ; Fri, 21 Feb 2025 16:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1740184450; x=1740789250; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vwm1CmURc5ve7fRU7CIVjr3XJe8XTIamKjt5b8I2oxA=; b=OUaLZ8oRu1P66C9ZZZkX3ynr5GVCRqOCfxm+eS10iyjZ/PQSQVzJcOLZ6xUj2SVdYN M4K8v7SJJNGtsVfIa8UAf/TytFgQB7jB17v0YqxAZeaJ0z7poxTRKJtsLNNfDGLEzCtl seyhz1IBRRwX+if/gK7lWjT9j8r22Ve4Q5tw8y7tH4v0VO86On+zdAarH3tOUkuAZpC+ 42QHcKAyfH9frZU0Zmd2KD7X742j4GBihhNWnbrr+XZUDJUe8nnJrCAFuMuLqqZIBe++ 7xlE0daBQ4baD0AJRZFXYr9quFZHlK3q3UVtm8HMqcrK9PO0mdFobh1wMMbzoIxycBMQ K8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740184450; x=1740789250; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vwm1CmURc5ve7fRU7CIVjr3XJe8XTIamKjt5b8I2oxA=; b=cHzeWEGWdKSwybvHg95zJvujnZSJIKgq7RiWtVozfaYbogXkIHGvHJlVs6LwGWkRgM KH/jVAiL//IWIKjb4q5ohmX/vWry7JwhaaQpN7FLQOuGY0dy4EP5ymAYVcPJtsVmwd47 XeXbbxoaiZe7rBnHYahmah2szcO3AJJGySdqUTS2qw2AIeqexefTYZKET+2UcXHZYOUT qtr7EQKBgID5ESmHnLudSbOMhmTX3PcPGJlCQ85o2ewsLrk+tK0ONvvJfk6/w15AMxOn STEx3B4QwAYtx7PO7VMTAXoPItzBz4BGFan/XDNJvxKWe4MomLNOZzKJ490XoXPRejOh ED+A== X-Forwarded-Encrypted: i=1; AJvYcCXME+jcOlIYL+DR6cqgv7/jhqT5DxM9spAa5UfucPK8M3rwYxWsUreT7Pd8xbQOf2KRdr26a54yZNo=@vger.kernel.org X-Gm-Message-State: AOJu0YzGJ0OUdt6BKNZ7wMoWEzfQtY9Yy7Cu9SjbFkgu3e/QooK4NcG+ C4ybvhG1uL7QBTl4Nq0hrGkXMzYRCHmR/cf68lljZHA5v5wI9BtZDfd1bRxwunIEH7gS8HWzf0Z r8+vg/WHSx+E8mUx5RrsuHfb1EwV6HNRKbpaP X-Gm-Gg: ASbGncs1Mz46KxuaAvhpOrdOTfLN07iSs/7jgN6pPqDbAmMtTgbXp2GM1ll1uKui1WM HSEUtwUx1ZcCtF8/XWOLu2Z93678sFsjkBXXfKRkAdoxFtLNCpEdrzJXsYoswf0pr5xU1oewAj+ WHJQvGzX0= X-Google-Smtp-Source: AGHT+IHU8mqrXQveakYlLhZ7AQnDt8Huldya+naR0jPDiYuZo2FksnUyR3yBLKwefOB052PduAKRpiO/vKqO0ObiYCs= X-Received: by 2002:a05:690c:3506:b0:6f6:c937:2cf4 with SMTP id 00721157ae682-6fbcc81835dmr37934927b3.23.1740184450404; Fri, 21 Feb 2025 16:34:10 -0800 (PST) Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250211-xattrat-syscall-v3-1-a07d15f898b2@kernel.org> <20250221.ahB8jei2Chie@digikod.net> In-Reply-To: <20250221.ahB8jei2Chie@digikod.net> From: Paul Moore Date: Fri, 21 Feb 2025 19:33:59 -0500 X-Gm-Features: AWEUYZkJvdf7eQZPTJrwhKnqZP-Y8wnVSUpipQ3Me6WvrrB1wQej040Y9lsHrww Message-ID: Subject: Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls To: Andrey Albershteyn , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= Cc: Richard Henderson , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Alexander Viro , Christian Brauner , Jan Kara , =?UTF-8?Q?G=C3=BCnther_Noack?= , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-xfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 21, 2025 at 10:08=E2=80=AFAM Micka=C3=ABl Sala=C3=BCn wrote: > > It looks security checks are missing. With IOCTL commands, file > permissions are checked at open time, but with these syscalls the path > is only resolved but no specific access seems to be checked (except > inode_owner_or_capable via vfs_fileattr_set). Thanks for reviewing the patch and catching this Micka=C3=ABl. I agree with the hooks identified and their placement; it should be fairly straightforward with only a few lines added in each case. --=20 paul-moore.com