From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43250C4332F for ; Tue, 20 Dec 2022 23:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234262AbiLTXbK (ORCPT ); Tue, 20 Dec 2022 18:31:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234178AbiLTXbJ (ORCPT ); Tue, 20 Dec 2022 18:31:09 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99D0C1FCE7 for ; Tue, 20 Dec 2022 15:31:07 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id d3so13812644plr.10 for ; Tue, 20 Dec 2022 15:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Zre1kotzR+gyUnyjZM5SkqNzTaEPBauNGGmkiFmJLxA=; b=Nf1RbDbe6Y7p3znBVUX7koicto5J7BA6jgcX2c87vxea33bkv885eV83wfLPpyOMZX FPwkPEZYpZIEIEUQjPIVz5H2c9MVNo82yrmz8ZPbwQigqsTOIDcGNVH7wkSEssQ8Pl99 u/q9rzfa2e3pi0GXOnhRM9WLI8JoeUI5Lx8PpVTz6+AkAYPQZvO67Bog+UXvM490HitC Mj6HC927l+M2MGRLlR07qQgp+ObRq4x/YEemGN4ULFMdxTHJzoIO1zc4urBglPkPkWDG tnT7vR0Lhix+ILtzZUJEqSvCWy76VA7dSJhWfywRVAwnMNJFKscL+XE0pduN+GsViM81 WVag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zre1kotzR+gyUnyjZM5SkqNzTaEPBauNGGmkiFmJLxA=; b=NiDY4rxj3vTi8D49J+lYqtDeuoRNMJ5qdE2HWG4by5S0VyEiC1nnDN75QesLpZY60+ ceT/NDsyAow/LO7VV4KXJthKqj4y1mDhyahi4UM6/vnjwNMovcznUwqpk4KpMtpcGiSx rIYWA7ZUDP8B8/LGyXBbw/wd5VNnfRRGgXKIxgEHSLClXhhVrCE4S2SsGwdiRno/j5Xn 5VreLY9DbHAzuMJZeob7vssWAKaC897lXAW9dna1wfkQLEaMEth+DGpkcP78jeL2Kg+X qjXjnr/hSCaRX+BDttRB3VR0qin2fvCoQpi7pXKwSm1ImkrRF86ngKpsSRXoRUEela8R ce5Q== X-Gm-Message-State: ANoB5pmtzFAB9LeqZoFAH0S/Dx0Dzb+GinaGbfRsyJgoV+gcRI0hwcDj crgtLqt79DSVGrxA7W1MB2Gu0/ZCAeGJ2B2O6U7Y X-Google-Smtp-Source: AA0mqf7+YJR0aQlb22cA8u1ukv0bd+pXUGYeqBMNcL0hZcYc3FUyoIGarrrn28B0nOfNbTsag/TgPOEscRMb7Pf8iqk= X-Received: by 2002:a17:902:9892:b0:186:c3b2:56d1 with SMTP id s18-20020a170902989200b00186c3b256d1mr81913259plp.15.1671579067046; Tue, 20 Dec 2022 15:31:07 -0800 (PST) MIME-Version: 1.0 References: <33f683794883676be88e503594ba094db2ff6bbb.1670606054.git.rgb@redhat.com> In-Reply-To: <33f683794883676be88e503594ba094db2ff6bbb.1670606054.git.rgb@redhat.com> From: Paul Moore Date: Tue, 20 Dec 2022 18:30:56 -0500 Message-ID: Subject: Re: [PATCH v5 1/3] fanotify: Ensure consistent variable type for response To: Richard Guy Briggs Cc: Linux-Audit Mailing List , LKML , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, Eric Paris , Steve Grubb , Jan Kara , Amir Goldstein Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Dec 12, 2022 at 9:06 AM Richard Guy Briggs wrote: > > The user space API for the response variable is __u32. This patch makes > sure that the whole path through the kernel uses u32 so that there is > no sign extension or truncation of the user space response. > > Suggested-by: Steve Grubb > Link: https://lore.kernel.org/r/12617626.uLZWGnKmhe@x2 > Signed-off-by: Richard Guy Briggs > --- > fs/notify/fanotify/fanotify.h | 2 +- > fs/notify/fanotify/fanotify_user.c | 6 +++--- > include/linux/audit.h | 6 +++--- > kernel/auditsc.c | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) Acked-by: Paul Moore (audit) -- paul-moore.com