From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [RFC PATCH 11/10] pipe: Add fsync() support [ver #2] Date: Sat, 2 Nov 2019 15:09:09 -0700 Message-ID: References: <25886.1572723272@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski Cc: David Howells , Konstantin Khlebnikov , Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , Nicolas Dichtel , raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block , LSM List , linux-fsdevel , Linux API , Linux Kernel Mailing List List-Id: linux-api@vger.kernel.org On Sat, Nov 2, 2019 at 3:03 PM Linus Torvalds wrote: > > On Sat, Nov 2, 2019 at 1:31 PM Andy Lutomirski wrot= e: > > > > Add in the fact that it=E2=80=99s not obvious that vmsplice *can* be us= ed correctly, and I=E2=80=99m wondering if we should just remove it or make= it just do write() under the hood. > > Sure it can. Just don't modify the data you vmsplice. It's really that si= mple. > > That said, if we don't have any actual users, then we should look at > removing it (maybe turning it into "write()" as you say). Not because > it's hard to use, but simply because it probably doesn't have that > many uses. Looking at debian code search, there are _some_ uses (including openssl and fuse): https://codesearch.debian.net/search?q=3D%3D+vmsplice%28&literal=3D1 but I didn't check any more closely what they do. Linus