From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE161C432BE for ; Fri, 23 Jul 2021 01:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC36560EBD for ; Fri, 23 Jul 2021 01:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233059AbhGWAfg (ORCPT ); Thu, 22 Jul 2021 20:35:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232966AbhGWAff (ORCPT ); Thu, 22 Jul 2021 20:35:35 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C51BC061575 for ; Thu, 22 Jul 2021 18:16:09 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id i18so21258yba.13 for ; Thu, 22 Jul 2021 18:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3GzZUiWRloPQrXBdUYorJDMZSlFJKnkE4RwHu5ZYLM4=; b=IAlCVu8/mqkfWitvqAfF6S/1PxmHsrL1hI3yjJtBfzQ89rf2bO8G3Vv4EmdUTjyCv4 vErCIaWL0RSz/07P0pjWzM0Szka8jRxHUncJUX/VcOsSXI5bqBfHCc9VrH8BuzHdCMxa xScBENnfqpq3t6Wz9djsWnyugd8bYwvHF00f+WSd7eXfSISchVbTd792koY6PtUhCMB8 F61QuaR2C7IkVoGlrIu/WkstgmvAzHIbXn9LQjmCyQAZCpNOgj78mN7vjhDzIP6ihwZt KIlL4qDOWPdRpnjLt4XbDSd5gL4XLGVADSaqIc3WQyVavvmEkIGrZSSo6+Gu+FqGME82 zryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3GzZUiWRloPQrXBdUYorJDMZSlFJKnkE4RwHu5ZYLM4=; b=t/CYcLKTqV+V54GPC57kZ8I3SoMqvNJcvivjgNcuoibnOndleOjdLCrG2Xv4D3HaKH EgzGRkwYS7S8SoM6qn9CVXVU2Csc9zXGEne4cPm6EdkBYN6GvPipPV2NW+j8I2a/UeaS KVVJ5lVJ3m6LCHahtCL+iOUCN/6JaKQecUIOuWtmyT60C9JHP4dMAJuubPgLcfiA8ur1 BorRPRTWOxXOjFKwiDfRVeWhb/Kcr+0wqCN8EyPZqEGi3kgGsmIy7x+mjZxb1di5/d+y MvcObOYtwB8Jn24SpFufdzsRvvhr29NpBR+hWEFi1flEQwi0A9D55Po4XWQvmFuCAjVd 0PfA== X-Gm-Message-State: AOAM531SJd/zdQ7bUH7TRPgb6Za5DykByOOLw2fIyJEID3s422o7ICSt f3SEHcUYhnG2clda0ubhyDpAa/sJYhnB1gpjK9zPJw== X-Google-Smtp-Source: ABdhPJyq45hMHallqmqyOyy6fSXBjwl/uWwFFwTNoBAyZ8V7mgCKBB69jXsoebr7Ozr+T0JmNGzVP/AhVgeCaqQB5Z0= X-Received: by 2002:a25:ba08:: with SMTP id t8mr3115977ybg.111.1627002968071; Thu, 22 Jul 2021 18:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: From: Suren Baghdasaryan Date: Thu, 22 Jul 2021 18:15:57 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease To: Andrew Morton Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Wed, Jul 21, 2021 at 1:59 PM Suren Baghdasaryan wrote: > > On Wed, Jul 21, 2021 at 1:51 PM Andrew Morton wrote: > > > > On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > > > > > This would not require moving other functions. > > > > > Would that be better than the current approach or the forward declaration? > > > > > > > > IMHO that could be an easy, possible alternative. > > > > > > Andrew, others? Should I follow this path instead? > > > > Whatever you prefer ;) > > I understand David's concern too well to ignore it, so I prefer to > follow this middle-ground approach if you don't mind :) v3 with the refactoring is posted at https://lore.kernel.org/patchwork/project/lkml/list/?series=509230