From: Arnd Bergmann <arnd@arndb.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Hannes Reinecke" <hare@suse.com>,
"y2038 Mailman List" <y2038@lists.linaro.org>,
"Linux API" <linux-api@vger.kernel.org>,
"Jackie Liu" <liuyun01@kylinos.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
"Stefan Bühler" <source@stbuehler.de>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Linux FS-devel Mailing List" <linux-fsdevel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Hristo Venev" <hristo@venev.name>
Subject: Re: [PATCH] io_uring: use __kernel_timespec in timeout ABI
Date: Tue, 1 Oct 2019 17:57:42 +0200 [thread overview]
Message-ID: <CAK8P3a19TDk0uo1eu4CcaKHvQCPUJGMjBV8Txtpgvg1ifAgW_A@mail.gmail.com> (raw)
In-Reply-To: <ca0a5bbe-c20e-d5be-110e-942c604ad2d7@kernel.dk>
On Tue, Oct 1, 2019 at 5:52 PM Jens Axboe <axboe@kernel.dk> wrote:
> On 10/1/19 9:49 AM, Arnd Bergmann wrote:
> > On Tue, Oct 1, 2019 at 5:38 PM Jens Axboe <axboe@kernel.dk> wrote:
> > What's wrong with using __kernel_timespec? Just the name?
> > I suppose liburing could add a macro to give it a different name
> > for its users.
>
> Just that it seems I need to make it available through liburing on
> systems that don't have it yet. Not a big deal, though.
Ah, right. I t would not cover the case of building against kernel
headers earlier than linux-5.1 but running on a 5.4+ kernel.
I assumed that that you would require new kernel headers anyway,
but if you have a copy of the io_uring header, that is not necessary.
> One thing that struck me about this approach - we then lose the ability to
> differentiate between "don't want a timed timeout" with ts == NULL, vs
> tv_sec and tv_nsec both being 0.
You could always define a special constant such as
'#define IO_URING_TIMEOUT_NEVER -1ull' if you want to
support for 'never wait if it's not already done' and 'wait indefinitely'.
> I think I'll stuck with that you had and just use __kernel_timespec in
> liburing.
Ok.
Arnd
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
next prev parent reply other threads:[~2019-10-01 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 20:20 [PATCH] io_uring: use __kernel_timespec in timeout ABI Arnd Bergmann
2019-10-01 14:09 ` Jens Axboe
2019-10-01 15:38 ` Jens Axboe
2019-10-01 15:49 ` Arnd Bergmann
2019-10-01 15:52 ` Jens Axboe
2019-10-01 15:57 ` Arnd Bergmann [this message]
2019-10-01 16:02 ` Jens Axboe
2019-10-01 16:07 ` Florian Weimer
2019-10-01 18:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a19TDk0uo1eu4CcaKHvQCPUJGMjBV8Txtpgvg1ifAgW_A@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hristo@venev.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=source@stbuehler.de \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).