From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10926C433F5 for ; Wed, 4 May 2022 12:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349398AbiEDMJR convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2022 08:09:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349352AbiEDMJE (ORCPT ); Wed, 4 May 2022 08:09:04 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D86332AC1; Wed, 4 May 2022 05:05:21 -0700 (PDT) Received: from mail-wm1-f47.google.com ([209.85.128.47]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mspu2-1o64sF3C2q-00tDXf; Wed, 04 May 2022 14:00:11 +0200 Received: by mail-wm1-f47.google.com with SMTP id p7-20020a05600c358700b00393e80c59daso2530300wmq.0; Wed, 04 May 2022 05:00:11 -0700 (PDT) X-Gm-Message-State: AOAM533SDCVqzQiAdKsV83vgiJE9VyJH9Jl2sQzi1xyjCxHP/8W/lFlE M/RrauBA2UJujaaNl1c8a9CIW84ywx7qwk6yP2E= X-Google-Smtp-Source: ABdhPJxa91M6kOpYUD0iTKIgWao6CfWQbX+SRQAAcnEVkI7cNck+veUzwJT66OrSTBCPZk65kSjp++m9nNZ6refLZnU= X-Received: by 2002:a7b:cc93:0:b0:394:2622:fcd9 with SMTP id p19-20020a7bcc93000000b003942622fcd9mr7695473wma.20.1651665611020; Wed, 04 May 2022 05:00:11 -0700 (PDT) MIME-Version: 1.0 References: <2c8c96f-a12f-aadc-18ac-34c1d371929c@linux.intel.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 4 May 2022 13:59:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] termbits: Convert octal defines to hex To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Arnd Bergmann , Greg KH , linux-serial , Jiri Slaby , Linux API , Ivan Kokshaysky , Matt Turner , alpha , Thomas Bogendoerfer , "open list:BROADCOM NVRAM DRIVER" , "James E.J. Bottomley" , Helge Deller , Parisc List , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev , linux-arch , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:7CQbFrqW4cTrqLaKVG3j35bzBmKn+IuU4tx6h+ezN6PVZKgk+sz 8qiTIxQWgKVg592Oz6fM8BuTAJRta1OJthsCcRFJWgMJrQl+8iOo18131rIlBhcQ167uw2s qAsXBkV140cw0H0Uw5CXNeANe/rq7NcMXdg9AUUoijd/XgP/QBj+C4gUWMGdBbcXYryCDEK fMwzJlPIbalz2Qph2RNqA== X-UI-Out-Filterresults: notjunk:1;V03:K0:COPjXxKqg1Q=:VZTn72NtlgaYBDBCvL5I0k M7DGX/NMGjayrppYB0LPSZo4Fb0C/Dund+x/w084MgQANdpltVj92fHlfclpNX3TSS7P9fFdO 1ZndGa8zjXzVRxASqTuOGxvwNskOIfVB/DP7LyZqQR9/x/7YmdHgAmJWBXNGXqoTzm5xTzNTw /wNGfn6qcX2yxiPbsHntjmfHuLU2Khbc9tg6j/7zboJOpTOUo5PCKtHtEoL+MPsfirWp8LZYc OISYXsoOceS3FeZw1OfzZ6P6nDeHDerMGHShA/EuI0zAEn06zgMJJCeWkZHU8rdUIyBarHA9c 9lf4M9ZI4N6QHZx7HrdA4zF5YhLq4WEUPjOrK1foApXnfxsgFX50MbWxhnJkm/QYsrp5NmwVG uz2nwueC1bbCdhA99DYuLquD97jx6gMrhpIU1dkUZwhy03A+q8nM2RA9HQ1gp7Fa8r7TZJf9g b1mnW7C5llZ+Sby/KMRChcy9Ll+o02WXKM9/aHmCQfrA/pHjsIliYNzDQLMOxhlTqfH6FAHFY Cel4dtDXgpwDpcgSHZcH87yZTC0RhtNZC5wWplk4WbKsbm7X+ZIahx3CwdwYchrSa7SoxyCIf ps3O+Y3fOmOWHWmToMrJW0OW0NeH96aemgaKzORFWNOiGXrWZf/0EuGkI9IgdnOkqWhkLtNuA B4aXh1nXwzlsqJuTsozi8kkASB5qQHn216j/ky+JHL/Yce2pQaA6Tho7m7QKLPKPS/lJmxq4w uxtW68qM3nLVpvOJwGksIEOeBfzsUTUgUjA48BW2yRDp/9AZ46oo+QJ5v1tmEwb8YyD0EWp00 M1jbs3JJDosCeiNtbb2VAKMtaAlSHZpTRf1fQbcy8OiJtLqwKM= Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Wed, May 4, 2022 at 10:33 AM Ilpo Järvinen wrote: > On Wed, 4 May 2022, Arnd Bergmann wrote: > > On Wed, May 4, 2022 at 9:20 AM Ilpo Järvinen wrote: > > > > > After applying the patch locally, I still see a bunch of whitespace > > differences in the > > changed lines if I run > > > > vimdiff arch/*/include/uapi/asm/termbits.h include/uapi/asm-generic/termbits.h > > > > I think this mostly because you left the sparc version alone (it already > > uses hex constants), but it may be nice to edit this a little more to > > make the actual differences stick out more. > > I took a look on further harmonizing, however, it turned out to be not > that simple. This is basically the pipeline I use to further cleanup the > differences and remove comments if you want to play yourself, just remove > stages from the tail to get the intermediate datas (gawk is required for > --non-decimal-data): I've played around with it some more to adjust the number of leading zeroes and the type of whitespace. This is what I ended up with on top of your patch: https://pastebin.com/raw/pkDPaKN1 Feel free to fold it into yours. Arnd