From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4108DC433F5 for ; Thu, 24 Feb 2022 07:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbiBXHGi (ORCPT ); Thu, 24 Feb 2022 02:06:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229925AbiBXHGh (ORCPT ); Thu, 24 Feb 2022 02:06:37 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADD3F2649B0; Wed, 23 Feb 2022 23:06:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E40CD61978; Thu, 24 Feb 2022 07:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47C7EC34100; Thu, 24 Feb 2022 07:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645686366; bh=d3iTCnmjiWI2WfX8T3i0lRHp9N81t6Yh8Z7V7FwGN/U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=d9kZ0BbVkyCyNqDMbIIl+9W1OVaOiHcqpofy9Tv0x+jjG5DysO9+U6Q2K4lcdfFyH fai03dHJQzajxq5x8dD/JFbdF1zJckhozUk8lR9cVmlk5bBWd0W6ERB7Zbxdjefy3a B8/SUsADYD0SQguWOueuCsugHgBSJ8wqUkSLkiLSqKWedW5ys5Z7/z6mU2vQUHnHJ6 T4vRyvf7dvKpTRGhlcWD3SzP2O+MDfjLinnJiEst0s0apfF0uwuaENIe6tuGMnmiQ2 f1b6FsJH1WZrXXQHaNQBk/Ix0arInQgA572KGEYojkJ/0uUcVIi+T6URqFtcgb3eKx YzcfTkJH+KZ5w== Received: by mail-wr1-f41.google.com with SMTP id n14so1094215wrq.7; Wed, 23 Feb 2022 23:06:06 -0800 (PST) X-Gm-Message-State: AOAM533IwfhdoMLynJ+bABIrvx9165dae9qEOAN49auVA5Wg4l9cRSuW wg6wjh0haKlmXfi2cxR8wCiOxEwWbvnr+Ck444Y= X-Google-Smtp-Source: ABdhPJyN7vOmEPkorPTffJc1X7o++TFchfjh5Aum2nyP+tyYB62T97KqiFOhsVfqhaexAyBFN29agtP9qBPfezDsID0= X-Received: by 2002:adf:a446:0:b0:1ed:c41b:cf13 with SMTP id e6-20020adfa446000000b001edc41bcf13mr1075883wra.407.1645686364180; Wed, 23 Feb 2022 23:06:04 -0800 (PST) MIME-Version: 1.0 References: <20220216131332.1489939-1-arnd@kernel.org> <20220216131332.1489939-8-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 24 Feb 2022 08:05:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 07/18] nios2: drop access_ok() check from __put_user() To: Dinh Nguyen Cc: Linus Torvalds , Christoph Hellwig , linux-arch , Linux-MM , Linux API , Arnd Bergmann , Linux Kernel Mailing List , Al Viro , Russell King - ARM Linux , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Stafford Horne , Helge Deller , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Mark Rutland , Heiko Carstens , Rich Felker , David Miller , Richard Weinberger , "the arch/x86 maintainers" , Max Filippov , "Eric W . Biederman" , Andrew Morton , Ard Biesheuvel , alpha , "open list:SYNOPSYS ARC ARCHITECTURE" , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, Feb 24, 2022 at 12:30 AM Dinh Nguyen wrote: > On 2/16/22 07:13, Arnd Bergmann wrote: From: Arnd Bergmann > > > > Unlike other architectures, the nios2 version of __put_user() has an > > extra check for access_ok(), preventing it from being used to implement > > __put_kernel_nofault(). > > > > Split up put_user() along the same lines as __get_user()/get_user() > > > > Signed-off-by: Arnd Bergmann > > Acked-by: Dinh Nguyen Thanks! Could you also have a look at patch 2 (uaccess: fix nios2 and microblaze get_user_8)? That one is actually more critical, and should be backported to stable kernels. Arnd