From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C294FC63777 for ; Sun, 22 Nov 2020 04:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CDF620885 for ; Sun, 22 Nov 2020 04:01:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2kk/o/n2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbgKVEB3 (ORCPT ); Sat, 21 Nov 2020 23:01:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:50590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727121AbgKVEB3 (ORCPT ); Sat, 21 Nov 2020 23:01:29 -0500 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47A81208B8 for ; Sun, 22 Nov 2020 04:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606017688; bh=LnEcfZ7EAuRy2LnECDQWn5gnjgsq8GFNBn8ODQ8+JHw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=2kk/o/n2UXsfdST6NrShZUKZx/bEouQTk/Uf/iK4FXK6jujwtSM0cvU5mDUlhoiCm JloGw20EL2XYMwmQM/5np5luC2U+XCYoz98vRUDswUQp7TGa3gY7ZKvEEu0wzGk+qN 1iCMFoIYtVZmO9fucvcghC0ljetLapqj1o2Vvfb8= Received: by mail-wr1-f54.google.com with SMTP id k2so15060254wrx.2 for ; Sat, 21 Nov 2020 20:01:28 -0800 (PST) X-Gm-Message-State: AOAM533G6c5Av/hMwz1ISK+DpagjX5oHFAxhqRUkJfPh6tQgXfr9bozt JdGq9ovaf0YujyTPnhK3aezMlvbY5025N12qh0Cplg== X-Google-Smtp-Source: ABdhPJya2Fm7AlpR23qNwFPbMhB3Yi5SpFa44AWfIgtph6ZFjNt5Z0ShzA45Sx29UK9mTBQd+usd0uxSXWq5vA+n26o= X-Received: by 2002:a5d:4e87:: with SMTP id e7mr5785186wru.70.1606017686782; Sat, 21 Nov 2020 20:01:26 -0800 (PST) MIME-Version: 1.0 References: <20201118032840.3429268-1-krisman@collabora.com> <20201118032840.3429268-4-krisman@collabora.com> <87a6vdmedy.fsf@collabora.com> <202011201618.62E507D@keescook> In-Reply-To: <202011201618.62E507D@keescook> From: Andy Lutomirski Date: Sat, 21 Nov 2020 20:01:10 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 3/7] kernel: Implement selective syscall userspace redirection To: Kees Cook Cc: Gabriel Krisman Bertazi , Andrew Lutomirski , Rich Felker , Thomas Gleixner , Christian Brauner , Peter Zijlstra , Matthew Wilcox , Shuah Khan , LKML , Linux API , "open list:KERNEL SELFTEST FRAMEWORK" , X86 ML , Paul Gofman , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Fri, Nov 20, 2020 at 4:18 PM Kees Cook wrote: > > On Thu, Nov 19, 2020 at 12:43:05PM -0500, Gabriel Krisman Bertazi wrote: > > The existing interface could be extended with a flags field as part of > > the opcode passed in argument 2, which is currently reserved, and then > > return a FD, just like seccomp(2) does. So it is not like the current > > patches couldn't be extended in the future if needed, unless I'm > > mistaken. > > Yes, I'd prefer this series go in as-is, and if there is a need for > extending the API, arg2 can have more values added. I agree. > > -- > Kees Cook