From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B6E4C433E4 for ; Tue, 25 Aug 2020 00:34:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 476E42074D for ; Tue, 25 Aug 2020 00:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598315649; bh=FZVk5iiXJbmA3My8loC+sCM7p8RHhlYbxo2KYPIse/o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=DiNJxt+8iQ63IWE6IIexOD1bdgGH6ImElN5I8OLj0Y4Zpom8UzBFmQs/QKJx/HMiI Tf+A8W3Ig6ycb3HUfwjCQQmE6bkpZ2irx8V9sRTq/e1xdxM9WqKWkNc/Wum/Bm7nrQ 1XmpGBgxe0sV5C9kH+9WFmqkBion95YuMOP/mhtY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728763AbgHYAeI (ORCPT ); Mon, 24 Aug 2020 20:34:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:44446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728761AbgHYAeA (ORCPT ); Mon, 24 Aug 2020 20:34:00 -0400 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C68B22B3F for ; Tue, 25 Aug 2020 00:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598315639; bh=FZVk5iiXJbmA3My8loC+sCM7p8RHhlYbxo2KYPIse/o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mggVYqUIgHbDQKb/yVaAMmhrthhgWbYYBwu714YhVe9OQ2/ALMq/Cy86XMLrV9SX/ uHsQgq2f4G38hwoV06S/mM/5jXTexbRiA/MbDFdzed59wrq9ZCjjKcezLf2jFRFip5 yOW67xQag00gSYB+iKbRbVfU9CrDRiNoY6/71ri0= Received: by mail-wm1-f50.google.com with SMTP id a65so706997wme.5 for ; Mon, 24 Aug 2020 17:33:59 -0700 (PDT) X-Gm-Message-State: AOAM533RVjAPxXRt7Y2U2V1yDzmWslAsdG96gxFV9tlIX1F4kVzJPUj5 vi6MRcvhLB1aIFk3pbLWbc4WYCXpEaNZzY1nody2iA== X-Google-Smtp-Source: ABdhPJxs5innMByMfHrDOfrJMbYWcoGG4lrxdYWHbQ0NbBl3UqboIJUvK4aNgCRUoVaifdvLV7DHlZhHzHiKtSmebvY= X-Received: by 2002:a1c:ba08:: with SMTP id k8mr1702940wmf.49.1598315637952; Mon, 24 Aug 2020 17:33:57 -0700 (PDT) MIME-Version: 1.0 References: <20200825002645.3658-1-yu-cheng.yu@intel.com> <20200825002645.3658-9-yu-cheng.yu@intel.com> In-Reply-To: <20200825002645.3658-9-yu-cheng.yu@intel.com> From: Andy Lutomirski Date: Mon, 24 Aug 2020 17:33:46 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v11 8/9] x86/vdso: Insert endbr32/endbr64 to vDSO To: Yu-cheng Yu Cc: X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , "open list:DOCUMENTATION" , Linux-MM , linux-arch , Linux API , Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Content-Type: text/plain; charset="UTF-8" Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu wrote: > > From: "H.J. Lu" > > When Indirect Branch Tracking (IBT) is enabled, vDSO functions may be > called indirectly, and must have ENDBR32 or ENDBR64 as the first > instruction. The compiler must support -fcf-protection=branch so that it > can be used to compile vDSO. > > Signed-off-by: H.J. Lu > Signed-off-by: Yu-cheng Yu > Acked-by: Andy Lutomirski I revoke my Ack. Please don't repeat the list of object files. Maybe add the option to CFL? --Andy