linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
	"Andrew Lutomirski" <luto@kernel.org>,
	"Daniel Mack" <daniel@zonque.org>,
	"Mickaël Salaün" <mic@digikod.net>,
	"Kees Cook" <keescook@chromium.org>, "Jann Horn" <jann@thejh.net>,
	"Tejun Heo" <tj@kernel.org>, "David Ahern" <dsahern@gmail.com>,
	"Thomas Graf" <tgraf@suug.ch>,
	"Michael Kerrisk" <mtk.manpages@gmail.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Linux API" <linux-api@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Network Development" <netdev@vger.kernel.org>
Subject: Re: Potential issues (security and otherwise) with the current cgroup-bpf API
Date: Mon, 19 Dec 2016 21:26:22 -0800	[thread overview]
Message-ID: <CALCETrXY4f4Fbxv+d4QV-Tfhbc0-tJUnXph6uAdMAOofy116RQ@mail.gmail.com> (raw)
In-Reply-To: <20161220045155.GC86803@ast-mbp.thefacebook.com>

On Mon, Dec 19, 2016 at 8:51 PM, Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
> On Mon, Dec 19, 2016 at 05:40:53PM -0800, Andy Lutomirski wrote:
>>
>> By the way, even if Alexei is right, the BPF_PROG_DETACH API doesn't
>> even take a reference to a BPF program as an argument.  What is it
>> supposed to do if this mechanism ever gets extended?
>
> we just add another field to that anonymous union just like
> we did for other commands and everything is backwards compatible.
> It's the basics of bpf syscall that we've been relying on for some
> time now and it worked just fine.

And what happens if you don't specify that member and two programs are attached?

--Andy

  reply	other threads:[~2016-12-20  5:26 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17 18:18 Potential issues (security and otherwise) with the current cgroup-bpf API Andy Lutomirski
2016-12-17 19:26 ` Mickaël Salaün
2016-12-17 20:02   ` Andy Lutomirski
2016-12-19 20:56 ` Alexei Starovoitov
2016-12-19 21:23   ` Andy Lutomirski
2016-12-20  0:02     ` Alexei Starovoitov
     [not found]       ` <20161220000254.GA58895-+o4/htvd0TDFYCXBM6kdu7fOX0fSgVTm@public.gmane.org>
2016-12-20  0:25         ` Andy Lutomirski
2016-12-20  1:43           ` Andy Lutomirski
     [not found]           ` <CALCETrU1_bDVLfokQ7zasHVmeq7S-R+603GEw59V_wuj4eE1hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-20  1:44             ` David Ahern
     [not found]               ` <2dbec775-6304-e44c-19c5-fbf07877e7b1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-20  1:56                 ` Andy Lutomirski
     [not found]                   ` <CALCETrUW2jEYmjSsOrPj+MAjkDGGUCw_rdxQh+5Er0r4ReGLnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-20  2:52                     ` David Ahern
2016-12-20  3:12                       ` Andy Lutomirski
2016-12-20  4:44                         ` Alexei Starovoitov
     [not found]                           ` <20161220044440.GB86803-+o4/htvd0TDFYCXBM6kdu7fOX0fSgVTm@public.gmane.org>
2016-12-20  5:27                             ` Andy Lutomirski
     [not found]                               ` <CALCETrVxkdZA3SsRv0KKhBz9YvNMsnmHSjS8HN1GHrgWRYNM1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-20  5:32                                 ` Alexei Starovoitov
2016-12-20  9:11                     ` Peter Zijlstra
     [not found]                       ` <20161220091150.GJ3124-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2017-01-03 10:25                         ` Michal Hocko
     [not found]                           ` <20170103102559.GA30129-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-01-16  1:19                             ` Tejun Heo
2017-01-17 13:03                               ` Michal Hocko
2017-01-17 13:32                                 ` Peter Zijlstra
2017-01-17 13:58                                   ` Michal Hocko
     [not found]                                     ` <20170117135830.GO19699-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-01-17 20:23                                       ` Andy Lutomirski
2017-01-18 22:18                                     ` Tejun Heo
2017-01-19  9:00                                       ` Michal Hocko
2016-12-20  3:18             ` Alexei Starovoitov
     [not found]               ` <20161220031802.GA77838-+o4/htvd0TDFYCXBM6kdu7fOX0fSgVTm@public.gmane.org>
2016-12-20  3:50                 ` Andy Lutomirski
2016-12-20  4:41                   ` Alexei Starovoitov
     [not found]                   ` <CALCETrXymvAo-9zhQe=amToz_fs9XGniK2KLZv5Fxc66qcUx6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-20 10:21                     ` Daniel Mack
2016-12-20 17:23                       ` Andy Lutomirski
     [not found]                         ` <CALCETrXyp2ddf4HRsEoN=qEwTBaezOUX2XWj6nxPcbc4t13svw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-20 18:36                           ` Daniel Mack
2016-12-20 18:49                             ` Andy Lutomirski
2016-12-21  4:01                               ` Alexei Starovoitov
2016-12-20  1:34         ` David Miller
     [not found]           ` <20161219.203422.500916400463091702.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-12-20  1:40             ` Andy Lutomirski
2016-12-20  4:51               ` Alexei Starovoitov
2016-12-20  5:26                 ` Andy Lutomirski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-01-17  5:18 (unknown), Andy Lutomirski
     [not found] ` <CALCETrW+ZQ1xMEfdEOzx6RK9ZoCvQiqQSnOyhDJ=-FZMwUbucg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-18 22:41   ` Potential issues (security and otherwise) with the current cgroup-bpf API Tejun Heo
     [not found]     ` <20170118224120.GG9171-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2017-01-19  0:18       ` Andy Lutomirski
     [not found]         ` <CALCETrXv3k+=C=9D5YGypzPk8_f4yo8ShQ3tM2fOo++gJFBM4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-19  0:59           ` Tejun Heo
2017-01-19  2:29             ` Andy Lutomirski
     [not found]               ` <CALCETrVrEnL4cvkdDu2LUhxmeOZ+SMEmF=yKKsm9OYoW2y1Kpg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-20  2:39                 ` Alexei Starovoitov
2017-01-20  4:04                   ` Andy Lutomirski
2017-01-23  4:31                     ` Alexei Starovoitov
     [not found]                       ` <20170123043154.GA93519-+o4/htvd0TDFYCXBM6kdu7fOX0fSgVTm@public.gmane.org>
2017-01-23 20:20                         ` Andy Lutomirski
     [not found]                           ` <CALCETrXK65itdDqYTdhB-Td8d-Hzj00dcDScUOUh9psCZN_cLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-03 21:07                             ` Andy Lutomirski
2017-02-03 23:21                               ` Alexei Starovoitov
     [not found]                                 ` <20170203232154.GA30114-+o4/htvd0TDFYCXBM6kdu7fOX0fSgVTm@public.gmane.org>
2017-02-04 17:10                                   ` Andy Lutomirski
2017-01-19  1:01           ` Mickaël Salaün

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALCETrXY4f4Fbxv+d4QV-Tfhbc0-tJUnXph6uAdMAOofy116RQ@mail.gmail.com \
    --to=luto@amacapital.net \
    --cc=alexei.starovoitov@gmail.com \
    --cc=daniel@zonque.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jann@thejh.net \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mic@digikod.net \
    --cc=mtk.manpages@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tgraf@suug.ch \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).