From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH] x86: always use SYSCALL_DEFINE* Date: Tue, 13 Mar 2018 23:18:08 +0000 Message-ID: References: <14A5C8D0-3F9D-486F-A20C-55849D70FC80@amazon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jann Horn , Dominik Brodowski Cc: "Tautschnig, Michael" , "x86@kernel.org" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jaswinder Singh , Andi Kleen List-Id: linux-api@vger.kernel.org On Tue, Mar 13, 2018 at 9:16 PM, Jann Horn wrote: > On Sat, Mar 10, 2018 at 12:55 PM, Tautschnig, Michael > wrote: >> All syscall arguments are passed in as types of the same byte size as >> unsigned long (width of full registers). Using a smaller type without a >> cast may result in losing bits of information. SYSCALL_DEFINE* introduce >> adequate type casts. All definitions of syscalls in x86 except for those >> patched here have already been using the appropriate SYSCALL_DEFINE*. > [...] >> diff --git a/arch/x86/kernel/ioport.c b/arch/x86/kernel/ioport.c >> index 2f72330..d98b2a3 100644 >> --- a/arch/x86/kernel/ioport.c >> +++ b/arch/x86/kernel/ioport.c >> @@ -23,7 +23,8 @@ >> /* >> * this changes the io permissions bitmap in the current task. >> */ >> -asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on) >> +SYSCALL_DEFINE3(sys_ioperm, unsigned long, from, unsigned long, num, int, >> + turn_on) > > Shouldn't this be "SYSCALL_DEFINE3(ioperm, [...]", without the "sys_"? > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html I think this patch will be obsoleted by a series of patches from Dominik.