From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v8 01/16] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel Date: Mon, 18 May 2015 13:47:06 +0200 Message-ID: References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-2-git-send-email-mcoquelin.stm32@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1431158038-3813-2-git-send-email-mcoquelin.stm32@gmail.com> Sender: linux-arch-owner@vger.kernel.org To: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Michal Marek Cc: Philipp Zabel , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Rob Herring , Geert Uytterhoeven , Jonathan Corbet , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Linus Walleij , Stefan Agner , Lee Jones , Joe Perches , Russell King , Andy Shevchenko , Paul Bolle , Peter Hurley , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton List-Id: linux-api@vger.kernel.org Hi Michal, 2015-05-09 9:53 GMT+02:00 Maxime Coquelin : > When Kernel is executed in place from ROM, the symbol addresses can be > lower than the page offset. > > Tested-by: Chanwoo Choi > Signed-off-by: Maxime Coquelin > --- > scripts/link-vmlinux.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index 86a4fe7..b055d9d 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -82,7 +82,7 @@ kallsyms() > kallsymopt="${kallsymopt} --all-symbols" > fi > > - if [ -n "${CONFIG_ARM}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then > + if [ -n "${CONFIG_ARM}" ] && [ -z "${CONFIG_XIP_KERNEL}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then > kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET" > fi > > -- > 1.9.1 > The get_maintainer.pl does not explicitly provide your name as maintainer for this file. But looking at MAINTAINERS file, I think you are the one for it. Do you confirm? If this is the case and you agree with the patch, could you consider taking it for v4.2? Thanks in advance, Maxime