linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alban Crequy <alban.crequy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Li Xi <pkuelelixi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	tytso-3s7WtUTddSA@public.gmane.org,
	adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
	jack-AlSwsSmVLrQ@public.gmane.org,
	viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
	hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Subject: Re: [v12 1/5] vfs: adds general codes to enforces project quota limits
Date: Sun, 12 Apr 2015 15:49:11 +0200	[thread overview]
Message-ID: <CAMXgnP7wohyiMOAVR6B5H8r3hYBCo0Cz3ofzG_AzRnjWytbYOA@mail.gmail.com> (raw)
In-Reply-To: <1428592477-8212-2-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>

On 9 April 2015 at 17:14, Li Xi <pkuelelixi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This patch adds support for a new quota type PRJQUOTA for project quota
> enforcement. Also a new method get_projid() is added into dquot_operations
> structure.
>(...)
> diff --git a/fs/quota/quota.c b/fs/quota/quota.c
> index 2aa4151..33b30b1 100644
> --- a/fs/quota/quota.c
> +++ b/fs/quota/quota.c
> @@ -30,7 +30,10 @@ static int check_quotactl_permission(struct super_block *sb, int type, int cmd,
>         case Q_XGETQSTATV:
>         case Q_XQUOTASYNC:
>                 break;
> -       /* allow to query information for dquots we "own" */
> +       /*
> +        * allow to query information for dquots we "own"
> +        * always allow querying project quota
> +        */

I would add a precision in the comment:

always allow querying project quota when the project id is mapped in
the current user namespace.

id is the id in the current user namespace. So quotas for unmapped
users, unmapped groups or unmapped projects cannot be queried.

  parent reply	other threads:[~2015-04-12 13:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 15:14 [v12 0/5] ext4: add project quota support Li Xi
2015-04-09 15:14 ` [v12 1/5] vfs: adds general codes to enforces project quota limits Li Xi
     [not found]   ` <1428592477-8212-2-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2015-04-12 13:49     ` Alban Crequy [this message]
2015-04-09 15:14 ` [v12 2/5] ext4: adds project ID support Li Xi
     [not found]   ` <1428592477-8212-3-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2015-04-10 23:37     ` Andreas Dilger
     [not found]       ` <C5339F6B-2DAE-4984-86CF-B2990CEC3550-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
2015-04-13 16:33         ` Li Xi
2015-04-09 15:14 ` [v12 3/5] ext4: adds project quota support Li Xi
2015-04-09 15:14 ` [v12 4/5] ext4: adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support Li Xi
2015-04-09 15:14 ` [v12 5/5] ext4: cleanup inode flag definitions Li Xi
     [not found] ` <1428592477-8212-1-git-send-email-lixi-LfVdkaOWEx8@public.gmane.org>
2015-04-12 15:36   ` [v12 0/5] ext4: add project quota support Alban Crequy
     [not found]     ` <CAMXgnP6RF4HPDyugvnMKn3rDnuG7j1cz-xFtEMWx4Va1rEHVEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-14  8:21       ` Jan Kara
     [not found]         ` <20150414082115.GB23327-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2015-04-14 10:07           ` Alban Crequy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMXgnP7wohyiMOAVR6B5H8r3hYBCo0Cz3ofzG_AzRnjWytbYOA@mail.gmail.com \
    --to=alban.crequy-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
    --cc=dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=jack-AlSwsSmVLrQ@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pkuelelixi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tytso-3s7WtUTddSA@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).