From: Cong Wang <xiyou.wangcong@gmail.com>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
linux-api@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
carlos@redhat.com, eblake@redhat.com,
Kumar Gala <galak@codeaurora.org>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] bridge: include in6.h in if_bridge.h for struct in6_addr
Date: Tue, 4 Nov 2014 16:39:59 -0800 [thread overview]
Message-ID: <CAM_iQpX-V60iTHBz3nFnJkNbEy1JvGkxu_8T1mwYYwd67WxBYA@mail.gmail.com> (raw)
In-Reply-To: <1415128881-30183-1-git-send-email-gregory.0xf0@gmail.com>
On Tue, Nov 4, 2014 at 11:21 AM, Gregory Fong <gregory.0xf0@gmail.com> wrote:
> if_bridge.h uses struct in6_addr ip6, but wasn't including the in6.h
> header. Thomas Backlund originally sent a patch to do this, but this
> revealed a redefinition issue: https://lkml.org/lkml/2013/1/13/116
>
> The redefinition issue should have been fixed by the following Linux
> commits:
> ee262ad827f89e2dc7851ec2986953b5b125c6bc inet: defines IPPROTO_* needed for module alias generation
> cfd280c91253cc28e4919e349fa7a813b63e71e8 net: sync some IP headers with glibc
>
> and the following glibc commit:
> 6c82a2f8d7c8e21e39237225c819f182ae438db3 Coordinate IPv6 definitions for Linux and glibc
>
> so actually include the header now.
>
> Reported-by: Colin Guthrie <colin@mageia.org>
> Reported-by: Christiaan Welvaart <cjw@daneel.dyndns.org>
> Reported-by: Thomas Backlund <tmb@mageia.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks for working on it!
next prev parent reply other threads:[~2014-11-05 0:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 19:21 [PATCH] bridge: include in6.h in if_bridge.h for struct in6_addr Gregory Fong
2014-11-05 0:39 ` Cong Wang [this message]
[not found] ` <1415128881-30183-1-git-send-email-gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-05 22:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpX-V60iTHBz3nFnJkNbEy1JvGkxu_8T1mwYYwd67WxBYA@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=carlos@redhat.com \
--cc=davem@davemloft.net \
--cc=eblake@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gregory.0xf0@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).