From: David Herrmann <dh.herrmann@gmail.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Phong Tran <tranmanphong@gmail.com>,
"open list:KERNEL SELFTEST F..." <linux-api@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/memfd: Run test on all architectures
Date: Wed, 17 Sep 2014 14:28:00 +0200 [thread overview]
Message-ID: <CANq1E4Q_KfDamkCMatGFYCQ0VPfc6tbd7sWT_z_qDeboiNzgNw@mail.gmail.com> (raw)
In-Reply-To: <1410821984-11160-1-git-send-email-bobby.prani@gmail.com>
Hi
On Tue, Sep 16, 2014 at 12:59 AM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Remove the dependence on x86 to run the memfd test. Verfied on 32-bit powerpc.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Now that most archs have __NR_memfd_create, this is:
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks
David
> ---
> tools/testing/selftests/memfd/Makefile | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
> index ad4ab01..b80cd10 100644
> --- a/tools/testing/selftests/memfd/Makefile
> +++ b/tools/testing/selftests/memfd/Makefile
> @@ -1,38 +1,17 @@
> -uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
> -ifeq ($(ARCH),i386)
> - ARCH := x86
> -endif
> -ifeq ($(ARCH),x86_64)
> - ARCH := x86
> -endif
> -
> CFLAGS += -D_FILE_OFFSET_BITS=64
> -CFLAGS += -I../../../../arch/x86/include/generated/uapi/
> -CFLAGS += -I../../../../arch/x86/include/uapi/
> CFLAGS += -I../../../../include/uapi/
> CFLAGS += -I../../../../include/
>
> all:
> -ifeq ($(ARCH),x86)
> gcc $(CFLAGS) memfd_test.c -o memfd_test
> -else
> - echo "Not an x86 target, can't build memfd selftest"
> -endif
>
> run_tests: all
> -ifeq ($(ARCH),x86)
> gcc $(CFLAGS) memfd_test.c -o memfd_test
> -endif
> @./memfd_test || echo "memfd_test: [FAIL]"
>
> build_fuse:
> -ifeq ($(ARCH),x86)
> gcc $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt
> gcc $(CFLAGS) fuse_test.c -o fuse_test
> -else
> - echo "Not an x86 target, can't build memfd selftest"
> -endif
>
> run_fuse: build_fuse
> @./run_fuse_test.sh || echo "fuse_test: [FAIL]"
> --
> 2.1.0
>
next prev parent reply other threads:[~2014-09-17 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 22:59 [PATCH] selftests/memfd: Run test on all architectures Pranith Kumar
2014-09-17 12:28 ` David Herrmann [this message]
2014-09-17 15:36 ` Shuah Khan
[not found] ` <5419AA71.4020506-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-09-17 15:39 ` Pranith Kumar
2014-09-17 15:39 ` David Herrmann
2014-09-17 15:41 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANq1E4Q_KfDamkCMatGFYCQ0VPfc6tbd7sWT_z_qDeboiNzgNw@mail.gmail.com \
--to=dh.herrmann@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=hughd@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).