On Thu Nov 19, 2026 at 6:34 PM CET, Amir Goldstein wrote: > On Sun, Nov 15, 2026 at 7:04 PM koraynilay wrote: >> >> Implement provenance time (ptime) in ksmbd, as introduced in a >> previous commit ("vfs: add provenance time (ptime)"). >> >> Map it to SMB's CreationTime, making it settable by SMB clients. When >> reporting CreationTime to clients, prioritize ptime over da.create_time >> memorized in the user.DOSATTRIB xattr. > > That doesn't sound like the right thing to do. > > If the server stored a CreationTime that client had set, you cannot > override this. Ah, yes, but how would we handle older files which get a custom CreationTime both before (in the xattr) and after (in ptime) a kernel upgrade? > When the client sets CreationTime, the server can decide if it can and wants > (may be a policy decision) to store CreationTime in PTIME and not store > it in user.DOSATTRIB. To fix the above problem we should probably keep storing it in both ptime and the xattr though. > Fun fact: the user.DOSATTRIB format also has a mask so storing the > creation time inside it is also optional. With my current patch series applied, when CreationTime gets set by a client, ksmbd writes it to ptime and fixes/heals the xattr (= removing the CREATE_TIME flag created by older kernels, see the other fun fact below). And another fun fact: until [1] ksmbd ignored the flags and just read/wrote the attribs every time :) so that can only be honored for files that have been written to/updated with newer kernels. (That's why there is the ((flags & CREATE_TIME) || da.create_time > 0) in my patch, and not just the flag check) Thanks, koraynilay [1]: https://lore.kernel.org/linux-cifs/20261115155308.415734-1-koray.fra@gmail.com/ > Thanks, > Amir.