From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795126385; b=0KcfGr4r+Fz/BIe6V/tFesXsJoXJiTaZ4izwBOvFhonGMUwU2dB7YrcUKcYy8WrzGeLc sLe1pA3SJI73wDK4Ri+ElXazV/Atv8G+lEYdkdvLWS9/bRfMJJo00PtbjmW7fjEtY1mnV ceGxrQoC5qyQaYrkbAdhguOlPA53Mc7DhJXFtibFHhG++y76WP/h4KgNSD824UMoVqUo7 /u1e0HoawBSjSq3ie//9Sg3B0Gv0NDjfpbweW8210SUtE01lYL///uTvZhqTytXNCffdc KZzsmXMsNygyMdwjYLO4bSfXF2yrk4NWIEWsHW9yAZBKjfMLEYsI5i2B1Z6S1AcmF9Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795126385; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To:X-Mailer: References:In-Reply-To; bh=IoYLwm6HerTHe4foGRx/rnGtvlKmmT7FHejTxyvI3lY=; b=Cm4lff316mer6/4hzOvTeRgsj6X+3oW8XPJMRIzuw3k1QL+kjRAKobttGZmqAdq/1teK uWE7rQXoO1DUHsZeRCgrRzd2jN7qkYhNBlwd7crMFWq5mTJdKaQa+catEr8wlM5vxUNhM yTO7nOML1e8xX3c1HTnDdQXPK3uB6Sz9GmL6ZQo0fI7HLctxQ2IG81OxKjh++MIcjGGdJ BMwkDDT7JlWCz/dyE03UB2zO+cCDAJiSoYUvovP67me8yJE7hbUPN5r1XdWqdEe+O8czr kbaY1o5g8kNlO72a0AchYuDtzGyL7SExF+KjxrV6Yan0BWlu3eqDVaxAUzr8SWUFYwg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=lJySXOd6; arc=none smtp.remote-ip=209.85.221.51 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 338B1606A33E for ; Thu, 19 Nov 2026 22:13:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 338B1606A33E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=lJySXOd6 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-490d59c3f0aso96740f8f.1 for ; Thu, 19 Nov 2026 14:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795126381; x=1795731181; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=IoYLwm6HerTHe4foGRx/rnGtvlKmmT7FHejTxyvI3lY=; b=lJySXOd6kt1Mf9579i+PqKhbbIDUlyG+putGxErLptt3tRxHAoefA+y8GVioFvjBol WaLSoJSBjP0wkS0+4HdljzaY2A21KXiUI547PDkeHgIDY0C48NIVWarlrtsldLKz1Xdf S9zJF4q2tt6095iDOzZhoPIfxFqzN8dJcUMR3A6r8bC4KThLG7sLxXkQmyLQxPuZN+qn 6CeROb7WSfaI4tZ+7OOEM0ahYm8a0G16oizVaOjzsfBU1R8lWSLiQSa4sU1RUudp9qSl y3iOCsJQuTn5qC2Ni5aq31sJhgAm571NGcnHh9sONKPS7agbY8SiwGBV3eMUr6kkJHwr UvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795126381; x=1795731181; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=IoYLwm6HerTHe4foGRx/rnGtvlKmmT7FHejTxyvI3lY=; b=E+ncYTKuTjEvoxikxFsQGSiJqNJzgZ3nOnI4ZkOSL3UDVlTzUzqU7V3aqBmyRaYMhb HE5MwS7CgBXlEG8bTFIx1y6I/IaHCuIQzQ3pII821JrxwLwUR/varIHK8UV1nuSav19P ydWBmsZ4C5ceVn8ARjTR4UZUm9z5LqyfkFReovFuJc2ZiTvAVorWCU7VxnNvwd1tLtxe Av+iZKFXoQqzdSGw0o4GHFso9JrzsBxo7Gepan9lCQkGddXVfK0bth20QNjMy2AgMzPu Z3AcT0s5ywcPYuVYm9Ltf/q89JLUg9VsRke6nj0AXj8aQCGSX/zdWwdCKGYs1C+noPzS P2Tw== X-Forwarded-Encrypted: i=1; AL+hErGH6LwPpJ6J4Qg1eAPRasorlmwQ8PW8J2mKvk6YQrcXwQOlePw1kdNOJI/A2Py9pSX9tPKHUvB9DhA=@vger.kernel.org X-Gm-Message-State: APuU4Z+5x0x6D7Es3RjfjAJXsuQA4yUqaD1904OK5RVaaqxxkgUuH8ZS 0WwApFLw2k+izlcHF3bzSt1rIRVWzsEqp5NX/2lRpvw12as61Hi2yDzq X-Gm-Gg: AZFdTZcTPzhaVB2A5NmicfzEHycy+F4doQ4gGKzM4dYnCUlS1dfSQxcolIfMXD30ZaK RbL5efkogMUbx5L69Km9eBr3lh5stNLeuL+Sfdy6OZjdx7iSasPQOoQQldIPEwGMUhU+mjPjtKs 6FeJLUUAdMhcYPbolvEsda1JHYmA6MEKiko8wSo0Q+/aVnVr/h7uSB3jXzLXqKPAPQsV9xhMsJC HzUIEh3CiPoNN8Yl5axErFLTOqNnIoRrwVeGhY2VwOZ5Gb7X10RS6wkbXB03fGpobHA2f295pbk 1MGadnH/sgBNUU83WGOiTnMIat4fLqO3zQUdcBjFv5ZsP5yANqRYAJsPmqmqfX5j1IvPvsUT7C5 8GUpI5CjjPZfloODZ3MUo72t27dJ/rOJOULzfYCLwHoik8241iyLz2ioU5fRcXrQ9TZ2XPiBAjH QTAAwXcoCa8K7y1ifnxzzOEQKTEHUHzK3YcrzHpd07q70YMDbGWRUo+TlYFv9FcpMXL3ckU/0cx fbh/IIHU6WBksh3gMxHzIfXx6kE4rocwPbymcjMoLGMyRFUlAz+2kVq+y8Vg4gkuNbjQWK4LwXM O+zGIdqmxWx9q6YHNbAZ4iIlfQ== X-Received: by 2002:a05:6000:4904:b0:4a6:60b2:afed with SMTP id ffacd0b85a97d-4abb3c37a2dmr1397766f8f.11.1795126381480; Thu, 19 Nov 2026 14:13:01 -0800 (PST) Received: from localhost ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab6c61f558sm1875580f8f.58.2026.11.19.14.12.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2026 14:13:00 -0800 (PST) X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=7470484374e391fd8d57fd43029902e8671499255fadfb82b8d5a6f90081; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Thu, 19 Nov 2026 23:12:58 +0100 Message-Id: Cc: "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , "Konstantin Komarov" , "Paulo Alcantara" , "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J . Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , =?utf-8?q?Pali_Roh=C3=A1r?= , , , , , , , , Subject: Re: [RFC PATCH v4 02/10] vfs: add fileattr_has_fsx_mask() From: "koraynilay" To: "Amir Goldstein" , "koraynilay" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> <20261115180343.576773-3-koray.fra@gmail.com> In-Reply-To: --7470484374e391fd8d57fd43029902e8671499255fadfb82b8d5a6f90081 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Thu Nov 19, 2026 at 8:36 PM CET, Amir Goldstein wrote: > On Sun, Nov 15, 2026 at 7:04=E2=80=AFPM koraynilay = wrote: >> >> Add fileattr_has_fsx_mask() as a helper to let filesystems check for >> unsupported xflags while allowing supported ones. Can be used in the >> same way as fileattr_has_fsx(). >> >> Also make fileattr_has_fsx() a wrapper around fileattr_has_fsx_mask(). >> >> Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.4.7 >> Signed-off-by: koraynilay >> --- >> include/linux/fileattr.h | 21 ++++++++++++++++++--- >> 1 file changed, 18 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h >> index 42b92ccdc583..ba7ed3b387d8 100644 >> --- a/include/linux/fileattr.h >> +++ b/include/linux/fileattr.h >> @@ -65,6 +65,23 @@ int copy_fsxattr_to_user(const struct file_kattr *fa,= struct fsxattr __user *ufa >> void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags); >> void fileattr_fill_flags(struct file_kattr *fa, u32 flags); >> >> +/** >> + * fileattr_has_fsx_mask - check for extended flags/attributes >> + * @fa: fileattr pointer >> + * @allowed_xflags_mask: additional xflags permitted >> + * >> + * Return: true if any attributes are present that are not represented = in >> + * ->flags or @allowed_xflags_mask. >> + */ >> +static inline bool fileattr_has_fsx_mask(const struct file_kattr *fa, >> + u32 allowed_xflags_mask) >> +{ >> + return fa->fsx_valid && >> + ((fa->fsx_xflags & ~(FS_XFLAG_COMMON | allowed_xflags_ma= sk)) || >> + fa->fsx_extsize !=3D 0 || fa->fsx_projid !=3D 0 || >> + fa->fsx_cowextsize !=3D 0); >> +} >> + > > Every patch in your series did: > > if (fileattr_has_fsx_mask(fa, EXFAT_SUPPORTED_XFLAGS)) > return -EOPNOTSUPP; > > if (fa->fsx_xflags_mask & ~EXFAT_SUPPORTED_XFLAGS) > return -EOPNOTSUPP; > > It looks like this helper is not as helpful as it could have been > and you have raised this question yourself in the cover letter. > > Effectively every filesystem that supports fileattr_set() already has > a defined SUPPORTED mask, so I think it's better to do the negated > something like: > > static inline bool fileattr_supported_fsx_mask(const struct file_kattr *f= a, > u32 supported) > { > if (!fa->fsx_valid) > return true; > if ((fa->fsx_xflags | fa->fsx_xflags_mask) & ~supported) > return false; > if (fa->fsx_extsize && > !(supported & (FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT))) > return false; > if (fa->fsx_cowextsize && !(supported & FS_XFLAG_COWEXTSIZE)) > return false; > if (fa->fsx_projid && !(supported & FS_XFLAG_PROJID)) > return false; > return true; > } > > > ... > > if (!fileattr_supported_fsx_mask(fa, EXFAT_SUPPORTED_XFLAGS)) > return -EOPNOTSUPP; > > >> /** >> * fileattr_has_fsx - check for extended flags/attributes >> * @fa: fileattr pointer >> @@ -74,9 +91,7 @@ void fileattr_fill_flags(struct file_kattr *fa, u32 fl= ags); >> */ >> static inline bool fileattr_has_fsx(const struct file_kattr *fa) >> { >> - return fa->fsx_valid && >> - ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize = !=3D 0 || >> - fa->fsx_projid !=3D 0 || fa->fsx_cowextsize !=3D 0); >> + return fileattr_has_fsx_mask(fa, 0); > > return !fileattr_supported_fsx_mask(fa, FS_XFLAG_COMMON); > > I hope I got this right. I think so yeah, though for me it's easier to think about it as "unsupported" instead of "supported", but the idea should be correct. Though yeah, this helper may not even be needed, I'll see if it's better to keep it and write it like you did here, or just remove it altogether and just do & ~SUPPORTED. Thanks, koraynilay > Thanks, > Amir. --7470484374e391fd8d57fd43029902e8671499255fadfb82b8d5a6f90081 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSgVimKafU5DQMcjcDmj22qf5IGXAUCav90agAKCRDmj22qf5IG XPKZAP0VIIYNYcMXcJcBnssVPLsh/PdS/1YfbeS+1fY2/mTfywEAh1K4KuZwkU+c so3nKRdXgi3OcK+mKOduMSp71HXfUgE= =ip1X -----END PGP SIGNATURE----- --7470484374e391fd8d57fd43029902e8671499255fadfb82b8d5a6f90081--