From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7643C64E8A for ; Mon, 30 Nov 2020 19:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D3072076E for ; Mon, 30 Nov 2020 19:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="1ZYQ1Sj1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729913AbgK3TVK (ORCPT ); Mon, 30 Nov 2020 14:21:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729920AbgK3TVF (ORCPT ); Mon, 30 Nov 2020 14:21:05 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01DD7C0613D2 for ; Mon, 30 Nov 2020 11:20:20 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id bj5so7036922plb.4 for ; Mon, 30 Nov 2020 11:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YPx6KAaJQYZ9LMgvuman8b1Zu51OwsYSMrhXlN/pSyo=; b=1ZYQ1Sj10JfNbvLVfhXcfbMu8dNtj3dcCtQWpB63cbeklmhlKJ0tjF3j5QDQjsflkW TqnuMAr7QJUnwRAqWOeLl3VGdiPNWH1Oux6wywgBh/f5yrPElz5PzS2FnxNprTJgtruH fCPthmg/AQzAvWJ4exQyMwwLU1nlM+NGy1VA9lpN4oM7AFqZ8EKVi3jC7gP4GyvhPKGH qUzCmTmJKtbBPlxrR8OV7m3HI+WkyFmIqC8I3t+Jqy5uIbGP1OJaASCQ+rRrjocGbTbr z5a4a7aP/jfXritiE6FQG42lzThw07ozaMJY2e6DdCumMSoLSlE+OGCCIa3be4CxZKCq 6LVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YPx6KAaJQYZ9LMgvuman8b1Zu51OwsYSMrhXlN/pSyo=; b=Sk54SQKi11khbQASN975aQ158a4oj36ndsuITBAHyBcl98lEuCHuY0VlFYOIQXr00X uczGv/RrGIYfBbr2WjQCBtbF38yewfAyrsF5ivXwLqGlc7mEOVwbWdIHWFO5FauM+xIr pYdC7wa5fN5kl8vW1egiK1p94THF7yYJg3FA/4+8Kpb4URlwNwCtDjMInIGxDaKENlJB dOZHsNFpolE5DQ0i97LDpFx8oKhyglyDXCtZOwAhsSnGmL/IjTbhwW+WEGGtCq/cpYeA YznyYBfK8zyt99GJMl/uDLCbhkLZpAdeR48ojjjdsIw7V8a21R+GLGo4aXpFtbxTo27Y 6iVg== X-Gm-Message-State: AOAM5328cgkIIMuXpvIMGk2I7fajbgEP7i0Tsux75zZculkJDc5vGMw5 bT1PgK23LXloCVtN9GS/igMcIQ== X-Google-Smtp-Source: ABdhPJwxmco5rDsraLzW/o1UM1b39rwGCsqNTj9Ovi3eTPRfSZLWiAeOXhOQs592Lg3/Fk+ksE9sGg== X-Received: by 2002:a17:902:9a4c:b029:d6:a250:ab9f with SMTP id x12-20020a1709029a4cb02900d6a250ab9fmr20349781plv.20.1606764019470; Mon, 30 Nov 2020 11:20:19 -0800 (PST) Received: from relinquished.localdomain ([2601:602:8b80:8e0::b2be]) by smtp.gmail.com with ESMTPSA id u1sm17363448pfn.181.2020.11.30.11.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 11:20:18 -0800 (PST) Date: Mon, 30 Nov 2020 11:20:17 -0800 From: Omar Sandoval To: dsterba@suse.cz, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig , Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v6 05/11] btrfs: fix check_data_csum() error message for direct I/O Message-ID: References: <20201123170956.GI8669@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123170956.GI8669@twin.jikos.cz> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Nov 23, 2020 at 06:09:56PM +0100, David Sterba wrote: > On Wed, Nov 18, 2020 at 11:18:12AM -0800, Omar Sandoval wrote: > > From: Omar Sandoval > > > > Commit 1dae796aabf6 ("btrfs: inode: sink parameter start and len to > > check_data_csum()") replaced the start parameter to check_data_csum() > > with page_offset(), but page_offset() is not meaningful for direct I/O > > pages. Bring back the start parameter. > > > > Fixes: 1dae796aabf6 ("btrfs: inode: sink parameter start and len to check_data_csum()") > > This is part of the subpage preparatory patches still in misc-next , I > can drop the part that removes the start parameter if you're going to > use it. To be clear, the original patch is buggy. It causes check_data_csum() to print nonsense for checksum errors encountered during direct I/O. So, this should be probably be folded in to the original patch.