Re: [PATCH v5 00/39] Shadow stacks for userspace

Edgecombe, Rick P
2023-01-25T19:46:19Z

On Fri, 2023-01-20 at 11:19 -0800, Kees Cook wrote:
> On Fri, Jan 20, 2023 at 05:27:30PM +0000, Edgecombe, Rick P wrote:
> > On Thu, 2023-01-19 at 14:26 -0800, Andrew Morton wrote:
> > > On Thu, 19 Jan 2023 13:22:38 -0800 Rick Edgecombe <
> > > rick.p.edgecombe@intel.com> wrote:
> > >
> > > > SHSTK
> > >
> > > Sounds like me trying to swear in Russian while drunk.
> > >
> > > Is there any chance of s/shstk/shadow_stack/g?
> >
> > I'm fine with the name change. I think shstk got debated and picked
> > early in the history of the series before I got involved. "shstk"
> > is
> > nice and short, but it's not completely clear what it is unless you
> > already know about shadow stack. So there is a tradeoff of clarity
> > and
> > line length/wrapping. Does anyone else have any strong opinions?
>
> I prefer SHSTK because it specifically means x86's hardware shadow
> stack from CET. Lots of things can (and have) implemented things
> called
> "shadow stack".

This makes sense to, especially if we can hide it more from the core-mm
code per David Hildebrand's suggestion. I guess I'll leave it for now
unless anyone else has a stronger opinion.