Re: [PATCH v5 18/39] mm: Handle faultless write upgrades for shstk

David Hildenbrand
2023-01-26T08:47:07Z

On 26.01.23 01:59, Edgecombe, Rick P wrote:
> On Wed, 2023-01-25 at 10:43 -0800, Rick Edgecombe wrote:
>> Thanks for your comments and ideas here, I'll give the:
>> pte_t pte_mkwrite(struct vm_area_struct *vma, pte_t pte)
>> ...solution a try.
>
> Well, it turns out there are some pte_mkwrite() callers in other arch's
> that operate on kernel memory and don't have a VMA. So it needed a new

Why not pass in NULL as VMA then and document the semantics? The less
similarly named but slightly different functions, the better :)

--
Thanks,

David / dhildenb