From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2BBEC43217 for ; Mon, 7 Nov 2022 19:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231887AbiKGTbA (ORCPT ); Mon, 7 Nov 2022 14:31:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231734AbiKGTa7 (ORCPT ); Mon, 7 Nov 2022 14:30:59 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F50E13D79; Mon, 7 Nov 2022 11:30:59 -0800 (PST) Received: from zn.tnic (p200300ea9733e71f329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e71f:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C04391EC0567; Mon, 7 Nov 2022 20:30:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667849457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FiC2SF6mLbQQATTVLkboJbWW/1xzPJVw8Z/9CQ1CTXQ=; b=lbmME/XkFS3JdPv6aAB6XNylON/HZUJV1deId/INk0cAc5GqXAsboWklVhY8qtxlzVUO7O b6W18VNF1nJFVO5wduQexpbHDWgBSL/XmPVh0zkNfyPbNHzrFEfaCln9NNRoxZfGfc30Ol 7Bpo9DyS+ewW6sMUsu2OA4wHpyZlFtA= Date: Mon, 7 Nov 2022 20:30:57 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "Eranian, Stephane" , "kirill.shutemov@linux.intel.com" , "dave.hansen@linux.intel.com" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "linux-doc@vger.kernel.org" , "Lutomirski, Andy" , "jamorris@linux.microsoft.com" , "arnd@arndb.de" , "tglx@linutronix.de" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "Yang, Weijiang" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "Shankar, Ravi V" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" , "akpm@linux-foundation.org" Subject: Re: [PATCH v3 04/37] x86/cpufeatures: Enable CET CR4 bit for shadow stack Message-ID: References: <20221104223604.29615-1-rick.p.edgecombe@intel.com> <20221104223604.29615-5-rick.p.edgecombe@intel.com> <14b4c6e3d5b7b259e832ff44e64597f1cf344ffe.camel@intel.com> <48643073afcca661971bd7475c04659e453113cb.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <48643073afcca661971bd7475c04659e453113cb.camel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Mon, Nov 07, 2022 at 07:19:21PM +0000, Edgecombe, Rick P wrote: > There was at one point, but there was a suggestion to remove in favor > of clearcpuid. I can add it back. Sounds like I need to school that "suggestor" about clearcpuid. :) For example, when doing this: 1625c833db93 ("x86/cpu: Allow feature bit names from /proc/cpuinfo in clearcpuid=") I even managed to prevent the kernel from booting. So clearcpuid= is definitely not for general consumption. So as said, please remove it from your whole patchset's text. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette