From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A1BC352A1 for ; Thu, 24 Nov 2022 17:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbiKXReV (ORCPT ); Thu, 24 Nov 2022 12:34:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbiKXReU (ORCPT ); Thu, 24 Nov 2022 12:34:20 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3E813182C for ; Thu, 24 Nov 2022 09:34:18 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id q7so2518835wrr.8 for ; Thu, 24 Nov 2022 09:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4XcU9QM1ckQIRe8QVhZPdinZjsfGER7s7lyyPku7DYQ=; b=R1b3oSBO1JQM5LWUbXVCjlamk8u5bPM5JN3ayETkQT+gate4ffVmiBGlW84XSnwPk/ b0XbSiqw+PMQe3qXaMcBSFpSViggoHXm0b6BP+faSQXldVowV3WTZYjG2sCyfuSx3Ist QZ6NwCs090UekQs7cZy5A9064ozKwMTb2EHafIvYWnXT+mSemqxEX/EqKvgYlXV+ELp/ kUodW+WY43ZZh1x48XR40d3KZHDW0KgRQ1nKrd5/tJzYA/BiGN9JtD7007zaCPZOYVpJ yMPPSTuqCMdelktj1zwIboW5EHbi2b6Im+FpTsFU3o7VJuIqZMTwyTgfHb7bG/AIqBfs vH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4XcU9QM1ckQIRe8QVhZPdinZjsfGER7s7lyyPku7DYQ=; b=y0gCgEqULt9ooWaUbId36fvfbIppnQ1D6HXbYd9gWASNYImV3ukPUVeIePJdciD9gO hlESKoZ6w0XxELjm63JGNeWinQD56rDRalVpEtLVrngKVDYj5pG+OSeGfVRZ/9UcbfvB kH1y6/k2LeZ38Xa7mgHkLytc6v2kdz+Pfm95aV0YV825P2z3vzmkkJFShEETVfeH/YGi AhzQGGx1aBj9HXkhCLC088QSNMr251kqL4WykalrVjK7uUxLzXF8PCsJX96P8sKm/jhN o6VcUOxMUwdDfG/eBBGCGs0UqeS9gvxgeV1Vki4or8NbUEcN2Qe9E2KAbql2LRG9Jk5s jksA== X-Gm-Message-State: ANoB5pkcQiA19UA2YkgfEC/MPPR0hbVJRMNDczDshPO14uXls4PSyUIj XYZpAZVK0KvcfRwv5e/pJH7xRw== X-Google-Smtp-Source: AA0mqf59SeeMbBnb9HJBK2F4/46LuJC45dS0pyoVhoePMQNWhplXAcRq5kUENsm8AZLBjko11x/Www== X-Received: by 2002:adf:fd01:0:b0:235:83aa:a6ed with SMTP id e1-20020adffd01000000b0023583aaa6edmr19825861wrr.543.1669311257016; Thu, 24 Nov 2022 09:34:17 -0800 (PST) Received: from vermeer ([145.224.92.100]) by smtp.gmail.com with ESMTPSA id j2-20020a5d6e42000000b0024194bba380sm1869088wrz.22.2022.11.24.09.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Nov 2022 09:34:16 -0800 (PST) Date: Thu, 24 Nov 2022 18:34:11 +0100 From: Samuel Ortiz To: Conor Dooley Cc: "Hongren (Zenithal) Zheng" , Palmer Dabbelt , Paul Walmsley , Albert Ou , Atish Patra , Anup Patel , Eric Biederman , Kees Cook , linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Michael Kerrisk , linux-man@vger.kernel.org, Jiatai He , Heiko Stuebner Subject: Re: [PATCH v3 2/3] RISC-V: uapi: add HWCAP for Bitmanip/Scalar Crypto Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, Nov 24, 2022 at 05:20:37PM +0000, Conor Dooley wrote: > On 24/11/2022 17:12, Samuel Ortiz wrote: > > [You don't often get email from sameo@rivosinc.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Thu, Nov 24, 2022 at 11:55:01AM +0000, Conor Dooley wrote: > >> On Thu, Nov 24, 2022 at 11:47:30AM +0100, Samuel Ortiz wrote: > >> > >>> Patch #1 is definitely needed regardless of which interface we pick for > >>> exposing the ISA strings to userspace. > >> > >> I took another look at #1, and I feel more confused about what > >> constitutes canonical order than I did before! If you know better than > >> I, and you probably do since you're interested in these 6 month old > >> patches, some insight would be appreciated! > > > > Assuming we don't go with hwcap, I dont think the order of the > > riscv_isa_ext_id enum matters that much? > > The chief put it in canonical order so that's good enough for me! > > > > > iiuc we're building the cpuinfo string from the riscv_isa_ext_data > > array, and I think the current code is incorrect: > > > > static struct riscv_isa_ext_data isa_ext_arr[] = { > > __RISCV_ISA_EXT_DATA(sscofpmf, RISCV_ISA_EXT_SSCOFPMF), > > __RISCV_ISA_EXT_DATA(sstc, RISCV_ISA_EXT_SSTC), > > __RISCV_ISA_EXT_DATA(svinval, RISCV_ISA_EXT_SVINVAL), > > __RISCV_ISA_EXT_DATA(svpbmt, RISCV_ISA_EXT_SVPBMT), > > __RISCV_ISA_EXT_DATA(zicbom, RISCV_ISA_EXT_ZICBOM), > > __RISCV_ISA_EXT_DATA(zihintpause, RISCV_ISA_EXT_ZIHINTPAUSE), > > __RISCV_ISA_EXT_DATA("", RISCV_ISA_EXT_MAX), > > }; > > > > zicbom and zihintpause should come before supervisor level extensions. > > I'm going to send a patch for that. > > idk, Palmer explicitly re-ordered this: > https://lore.kernel.org/linux-riscv/20220920204518.10988-1-palmer@rivosinc.com/ > > By my reading of the isa manual, what Palmer did is correct as > those are not "Additional Standard Extensions". /shrug Hmm, by their name (Z[a-b]+) they are Additional Standard Extensions. What am I missing? Cheers, Samuel. >