From: Michal Hocko <mhocko@suse.com>
To: Zhongkun He <hezhongkun.hzk@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [External] Re: [PATCH v2] mm: add new syscall pidfd_set_mempolicy().
Date: Tue, 22 Nov 2022 09:40:15 +0100 [thread overview]
Message-ID: <Y3yK78HMSVA/Q6CS@dhcp22.suse.cz> (raw)
In-Reply-To: <ff3e9255-028a-7174-3608-2d9c362bdaf7@bytedance.com>
On Tue 22-11-22 16:33:09, Zhongkun He wrote:
> Hi Michal, thanks for your replay and suggestions.
>
> >
> > Yes the memory consumption is going to increase but the question is
> > whether this is something that is a real problem. Is it really common to
> > have many vmas with a dedicated policy?
>
> Yes, it does not a realy problem.
>
> >
> > What I am arguing here is that there are essentially 2 ways forward.
> > Either we continue to build up on top of the existing and arguably very
> > fragile code and make it even more subtle or follow a general pattern of
> > a proper reference counting (with usual tricks to reduce cache line
> > bouncing and similar issues). I do not really see why memory policies
> > should be any different and require very special treatment.
> >
>
> I got it. It is rather subtle and easy to get wrong if we push forward
> with the existing way and it is a good opportunity to get from the
> existing subtle model. I will try that on next version.
Thanks for being receptive to the review feedback!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-11-22 8:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 8:40 [PATCH v2] mm: add new syscall pidfd_set_mempolicy() Zhongkun He
2022-11-11 19:27 ` Andrew Morton
2022-11-13 16:41 ` [External] " Zhongkun He
2022-11-14 11:44 ` Michal Hocko
2022-11-14 11:46 ` Michal Hocko
2022-11-14 17:52 ` Michal Hocko
2022-11-14 15:12 ` Zhongkun He
2022-11-14 18:12 ` Michal Hocko
2022-11-15 7:39 ` Zhongkun He
2022-11-16 11:28 ` Zhongkun He
2022-11-16 14:57 ` Michal Hocko
2022-11-17 7:19 ` Zhongkun He
2022-11-21 14:38 ` Michal Hocko
2022-11-22 8:33 ` Zhongkun He
2022-11-22 8:40 ` Michal Hocko [this message]
2022-11-14 9:24 ` Zhongkun He
2022-11-12 2:09 ` kernel test robot
2022-11-16 7:04 ` Huang, Ying
2022-11-16 9:38 ` [External] " Zhongkun He
2022-11-16 9:44 ` Michal Hocko
2022-11-17 6:29 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3yK78HMSVA/Q6CS@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=hezhongkun.hzk@bytedance.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).