From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pawel Laszczak <pawell@cadence.com>
Cc: Peter Chen <peter.chen@kernel.org>,
balbi@kernel.org, gregkh@linuxfoundation.org,
linux-api@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kurahul@cadence.com
Subject: Re: [PATCH 1/2] usb: gadget: uvc: Updating bcdUVC field to 0x0110
Date: Sun, 14 Mar 2021 04:18:32 +0200 [thread overview]
Message-ID: <YE1yeEPwHoMgML0s@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210314015846.GB17526@b29397-desktop>
Hello Pawel,
Thank you for the patch.
On Sun, Mar 14, 2021 at 09:58:46AM +0800, Peter Chen wrote:
> On 21-03-08 11:27:34, Pawel Laszczak wrote:
> > From: Pawel Laszczak <pawell@cadence.com>
> >
> > Command Verifier during UVC Descriptor Tests (Class Video Control
> > Interface Descriptor Test Video) compleins about:
>
> %s/compleins/complains
>
> > Video Control Interface Header bcdUVC is 0x0100. USB Video Class
> > specification 1.0 has been replaced by 1.1 specification
> > (UVC: 6.2.26) Class Video Control Interface Descriptor bcdUVC is not 1.1
>
> What does this (UVC: 6.2.26) mean? There are only 4 chapters for this
> spec, Am I something wrong?
I assume this is a reference to a test case in the test suite.
> > Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> > ---
> > drivers/usb/gadget/function/uvc_configfs.c | 2 +-
> > drivers/usb/gadget/legacy/webcam.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c
> > index 00fb58e50a15..cd28dec837dd 100644
> > --- a/drivers/usb/gadget/function/uvc_configfs.c
> > +++ b/drivers/usb/gadget/function/uvc_configfs.c
> > @@ -231,7 +231,7 @@ static struct config_item *uvcg_control_header_make(struct config_group *group,
> > h->desc.bLength = UVC_DT_HEADER_SIZE(1);
> > h->desc.bDescriptorType = USB_DT_CS_INTERFACE;
> > h->desc.bDescriptorSubType = UVC_VC_HEADER;
> > - h->desc.bcdUVC = cpu_to_le16(0x0100);
> > + h->desc.bcdUVC = cpu_to_le16(0x0110);
> > h->desc.dwClockFrequency = cpu_to_le32(48000000);
> >
> > config_item_init_type_name(&h->item, name, &uvcg_control_header_type);
> > diff --git a/drivers/usb/gadget/legacy/webcam.c b/drivers/usb/gadget/legacy/webcam.c
> > index a9f8eb8e1c76..3a61de4bb2b1 100644
> > --- a/drivers/usb/gadget/legacy/webcam.c
> > +++ b/drivers/usb/gadget/legacy/webcam.c
> > @@ -90,7 +90,7 @@ static const struct UVC_HEADER_DESCRIPTOR(1) uvc_control_header = {
> > .bLength = UVC_DT_HEADER_SIZE(1),
> > .bDescriptorType = USB_DT_CS_INTERFACE,
> > .bDescriptorSubType = UVC_VC_HEADER,
> > - .bcdUVC = cpu_to_le16(0x0100),
> > + .bcdUVC = cpu_to_le16(0x0110),
> > .wTotalLength = 0, /* dynamic */
> > .dwClockFrequency = cpu_to_le32(48000000),
> > .bInCollection = 0, /* dynamic */
The change looks good to me. With the typo in the commit message fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-03-14 2:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 10:27 [PATCH 1/2] usb: gadget: uvc: Updating bcdUVC field to 0x0110 Pawel Laszczak
2021-03-08 10:27 ` [PATCH 2/2] usb: webcam: Invalid size of Processing Unit Descriptor Pawel Laszczak
2021-03-14 1:46 ` Peter Chen
2021-03-14 2:30 ` Laurent Pinchart
2021-03-14 1:58 ` [PATCH 1/2] usb: gadget: uvc: Updating bcdUVC field to 0x0110 Peter Chen
2021-03-14 2:18 ` Laurent Pinchart [this message]
2021-03-15 5:10 ` Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE1yeEPwHoMgML0s@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).