Re: [PATCH v26 24/30] x86/cet/shstk: Introduce shadow stack token setup/verify routines

Yu, Yu-cheng
2021-05-21T16:18:03Z

On 5/17/2021 12:45 AM, Borislav Petkov wrote:
> On Tue, Apr 27, 2021 at 01:43:09PM -0700, Yu-cheng Yu wrote:

[...]

>> +
>> + if ((!ia32 && !IS_ALIGNED(ssp, 8)) || !IS_ALIGNED(ssp, 4))
>
> Flip this logic:
>
> if ((ia32 && !IS_ALIGNED(ssp, 4)) || !IS_ALIGNED(ssp, 8))

If !IS_ALIGNED(ssp, 4), then certainly !IS_ALIGNED(ssp, 8).
This has to be as-is, I think.

Thanks,
Yu-cheng