Re: [PATCH v28 14/32] mm: Introduce VM_SHADOW_STACK for shadow stack memory

Yu, Yu-cheng
2021-08-17T18:35:16Z

On 8/16/2021 9:35 AM, Borislav Petkov wrote:
> On Thu, Jul 22, 2021 at 01:52:01PM -0700, Yu-cheng Yu wrote:
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index eb97468dfe4c..02c70198b989 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -662,6 +662,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
>> #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR
>> [ilog2(VM_UFFD_MINOR)] = "ui",
>> #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */
>> +#ifdef CONFIG_ARCH_HAS_SHADOW_STACK
>> + [ilog2(VM_SHADOW_STACK)]= "ss",
>> +#endif
>
>
> ERROR: spaces required around that '=' (ctx:VxW)
> #109: FILE: fs/proc/task_mmu.c:666:
> + [ilog2(VM_SHADOW_STACK)]= "ss",
> ^
>
> total: 1 errors, 0 warnings, 49 lines checked
>
> Please integrate scripts/checkpatch.pl into your patch creation
> workflow. Some of the warnings/errors *actually* make sense.
>

I will add a space there.

Thanks,
Yu-cheng