Re: [PATCH v29 25/32] x86/cet/shstk: Handle thread shadow stack

Yu, Yu-cheng
2021-08-26T17:33:21Z

On 8/26/2021 10:28 AM, Borislav Petkov wrote:
> On Thu, Aug 26, 2021 at 10:22:29AM -0700, H.J. Lu wrote:
>>>> + /*
>>>> + * Earlier clone() does not pass stack_size. Use RLIMIT_STACK and
>>>
>>> What is "earlier clone()"?
>>
>> clone() doesn't have stack size info which was added to clone3().
>
> /me goes and reads the manpage...
>
> clone3()
> The clone3() system call provides a superset of the functionality of the older
> clone() interface. It also provides a number of API improvements, including:
> space for additional flags bits; cleaner separation in the use of various argu‐
> ments; and the ability to specify the size of the child's stack area.
>
> Aha, Yu-cheng, pls use those words to make your comment understandable.
>
> Thx.
>

Sure!

Yu-cheng