Re: [PATCH v11 07/10] btrfs-progs: receive: process fallocate commands

Nikolay Borisov
2021-10-21T14:21:08Z

On 1.09.21 г. 20:01, Omar Sandoval wrote:
> From: Boris Burkov <boris@bur.io>
>
> Send stream v2 can emit fallocate commands, so receive must support them
> as well. The implementation simply passes along the arguments to the
> syscall. Note that mode is encoded as a u32 in send stream but fallocate
> takes an int, so there is a unsigned->signed conversion there.
>
> Signed-off-by: Boris Burkov <boris@bur.io>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

However, kernel support for this hasn't landed, the kernel counterpart
patches add definitions but don't actually implement the code. BY the
looks of it it would seem that the proper send stream versioning could
be added first before any of this code lands. In this case we can simply
have the encoded writes stuff as protocol version 2 and leave the rest
of the commands for v3 for example.