From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EDCC433EF for ; Thu, 18 Nov 2021 19:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B96E66137B for ; Thu, 18 Nov 2021 19:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231176AbhKRTWm (ORCPT ); Thu, 18 Nov 2021 14:22:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbhKRTWm (ORCPT ); Thu, 18 Nov 2021 14:22:42 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0510C061574 for ; Thu, 18 Nov 2021 11:19:41 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id m14so7012157pfc.9 for ; Thu, 18 Nov 2021 11:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r/KCuEUuq7HzUmnTa9vj1McLqk0uyhbLn1CfNmt60cQ=; b=jfXtz1Y1XN8nbrgy00oy1MwWhtkc2qIsXeS3Dtw2B3fzHGRQ56+xM2e1BBNduKUD7E 4jY2J40/ZxOChAEf5oVQukT1sGJUWk2YqqdOexqqrJjytpys+L/LqcQbENa0Y9Wdhy2K /TNownk5/0dWnP1Cv7I2cgQR1/bvf3rAtzhN7XdxA1vVZJDDCNYsau55Zb9UD57ksSj5 Q/XugRU9NtEUiYm3ZPKK59HDsfXcP2cvzS2jra1AKKzhje4osNfmECbbEghnIswFQ1Y4 4BonuIZw+XSF35CtGD9V+EsPeujSJ8U9Ra25LbUc0xcGUVUJYQDZfYfcw1T2gaNUTeuV VW4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r/KCuEUuq7HzUmnTa9vj1McLqk0uyhbLn1CfNmt60cQ=; b=0bd+VUShYtOj9Vj+/HzowpOxSxXL0f7CVIY65XBnuRh+lNMtAEtP26ZJqxLIyVn/eT uE3tVeBibsKxGS3V7W5V9q2eAgFt3JGgXe529/vDVeLKIE4OfV3ePLvQI0mqn4rMnmsv 7/5sg4sZiTErQk8/yGH+ALalHc0QY6ObXwTaE5WhRUGvAdp0DtHnAyl/s0GUkbjDiI3a pvwlgtGqbV1pMiSJhXCqqSY2JYkxFxM6ni9swJ7CdzdzYKEKoz2ORMpD5K9NeEPa6qv3 inqb/aFRzUl9FJ8MH/nzEB5ShDhNHVWa5H5wEjFVOXNI9br6pDp/RlfFgrJCVeUw5fVz B9zA== X-Gm-Message-State: AOAM533CkCvw0pl3H94crhiNcQjPGoJvlGz85MjrEfFqlwtcirE1ru/o qTwr48txbXCq50nOZzO8egNA9g== X-Google-Smtp-Source: ABdhPJwRma8uUjJdafphLfaYQlBBCX12xP60toVWSBoYNSwsoZu/VeA3khvxwwWwjNRWHmOmDIWWUg== X-Received: by 2002:a63:d80c:: with SMTP id b12mr12980196pgh.331.1637263181350; Thu, 18 Nov 2021 11:19:41 -0800 (PST) Received: from relinquished.localdomain ([2620:10d:c090:400::5:174e]) by smtp.gmail.com with ESMTPSA id oc10sm9862283pjb.26.2021.11.18.11.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 11:19:40 -0800 (PST) Date: Thu, 18 Nov 2021 11:19:39 -0800 From: Omar Sandoval To: linux-btrfs@vger.kernel.org, Alexander Viro , Christoph Hellwig , Linus Torvalds Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v11 01/14] fs: export rw_verify_area() Message-ID: References: <9cd494dbd55c46a22f07c56ca42a399af78accd1.1630514529.git.osandov@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cd494dbd55c46a22f07c56ca42a399af78accd1.1630514529.git.osandov@fb.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Wed, Sep 01, 2021 at 10:00:56AM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > I'm adding Btrfs ioctls to read and write compressed data, and rather > than duplicating the checks in rw_verify_area(), let's just export it. > > Reviewed-by: Josef Bacik > Signed-off-by: Omar Sandoval > --- > fs/internal.h | 5 ----- > fs/read_write.c | 1 + > include/linux/fs.h | 1 + > 3 files changed, 2 insertions(+), 5 deletions(-) Could I please get an ack from the VFS side on this patch and "fs: export variant of generic_write_checks without iov_iter"? We're going the route of doing this as a Btrfs ioctl since we couldn't agree on a generic interface, so this is all I need from the VFS.