From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F26C433EF for ; Tue, 4 Jan 2022 19:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234809AbiADTGk (ORCPT ); Tue, 4 Jan 2022 14:06:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232289AbiADTGk (ORCPT ); Tue, 4 Jan 2022 14:06:40 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30556C061784 for ; Tue, 4 Jan 2022 11:06:40 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id s15so302052plg.12 for ; Tue, 04 Jan 2022 11:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wIU3J482L2HImj/M7R+fXYKFsH0w5gR4YGEoAmTcGjc=; b=JqUfSCH0gNRmBEZivXmIZBqiJWZC3f0gKXawXUk/5m81ir0nsEab8NnikNVCnTcv58 DPY/ZNMzske4DAC3qW8/DLG5yzRvXWVhuec4ZfWH2YXtvLWPKvNcuksYK9i40dwOcMsP t6wQdZzdgqdWepVsDdwp1di0fLpKCOEH2XMYCtSYRmSTjflbk2gGiGDBKS1eX1xPLZRQ q/To+qpyyGftKnvUPpKii3aMYeQXLUAHc/jqnx54CAU+1xT5xU1Loi827jxvy+irpYRh AENMWfS4vjakeqFse5b3PrOSfU7XWqMqWP9U3MTNjZrqHOZXCK4QXcpG57MOvBety5jO 5rrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wIU3J482L2HImj/M7R+fXYKFsH0w5gR4YGEoAmTcGjc=; b=uW/QhqHWaXquWTzPyXLM/bOLWyyBjB52+PmC82fy8gMeYLzh4sdviVaxa9HWFIlbJU QJRlK+7q1w3ViRwA+Nm4GznKQlX5AMrk9i54LOzdi+f5UCOUqfembEwTIcjf79yd51wX 4uk+3clOWNiOxQpMQ3zBAEUZBq6YrvAMGqISRIlIEdf3txL9Zh+qGpOhTy8Oqhmf69do /4e5FWY1wSmMOMzkOiQg7EIc7Tf1OLG7RTrYNZ7VTLNBPPvCT7os04ISjIXl5LZ3IHCL AstCsDAqtrz10IX2qLvfKbv37bNOf9JaiPHAAbVHMVlURJayO9JkcWnFxPp8/UELwCO1 MRnw== X-Gm-Message-State: AOAM530xbAVenhjzdFM2h6y/ERvaCqBulVIRkCPNdbAjtYIpBGtSDn11 kB/VhzksqCUsSwzGrPPYnqz8qQ== X-Google-Smtp-Source: ABdhPJx2Knho2SUpw0270NeHzwWXeefQ77+9gVkZzvHPJPl8XnmGVGi0b0nSalDE/G82t9/BjYsRAA== X-Received: by 2002:a17:90b:1b04:: with SMTP id nu4mr19349907pjb.205.1641323199661; Tue, 04 Jan 2022 11:06:39 -0800 (PST) Received: from relinquished.localdomain ([2620:10d:c090:400::5:7bfc]) by smtp.gmail.com with ESMTPSA id x40sm40917010pfu.185.2022.01.04.11.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 11:06:39 -0800 (PST) Date: Tue, 4 Jan 2022 11:06:38 -0800 From: Omar Sandoval To: linux-btrfs@vger.kernel.org, Alexander Viro , Christoph Hellwig , Linus Torvalds Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v11 01/14] fs: export rw_verify_area() Message-ID: References: <9cd494dbd55c46a22f07c56ca42a399af78accd1.1630514529.git.osandov@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, Nov 18, 2021 at 11:19:39AM -0800, Omar Sandoval wrote: > On Wed, Sep 01, 2021 at 10:00:56AM -0700, Omar Sandoval wrote: > > From: Omar Sandoval > > > > I'm adding Btrfs ioctls to read and write compressed data, and rather > > than duplicating the checks in rw_verify_area(), let's just export it. > > > > Reviewed-by: Josef Bacik > > Signed-off-by: Omar Sandoval > > --- > > fs/internal.h | 5 ----- > > fs/read_write.c | 1 + > > include/linux/fs.h | 1 + > > 3 files changed, 2 insertions(+), 5 deletions(-) > > Could I please get an ack from the VFS side on this patch and "fs: > export variant of generic_write_checks without iov_iter"? We're going > the route of doing this as a Btrfs ioctl since we couldn't agree on a > generic interface, so this is all I need from the VFS. Ping.