From: Matthew Wilcox <willy@infradead.org>
To: Jeremy Bongio <bongiojp@gmail.com>
Cc: Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4] Add ioctls to get/set the ext4 superblock uuid.
Date: Wed, 20 Jul 2022 04:18:51 +0100 [thread overview]
Message-ID: <Ytd0G0glVWdv+iaD@casper.infradead.org> (raw)
In-Reply-To: <20220719234131.235187-1-bongiojp@gmail.com>
On Tue, Jul 19, 2022 at 04:41:31PM -0700, Jeremy Bongio wrote:
> +/*
> + * Structure for EXT4_IOC_GETFSUUID/EXT4_IOC_SETFSUUID
> + */
> +struct fsuuid {
> + __u32 fsu_len;
> + __u32 fsu_flags;
> + __u8 fsu_uuid[];
> +};
A UUID has a defined size (128 bits):
https://en.wikipedia.org/wiki/Universally_unique_identifier
Why are we defining flags and len?
next prev parent reply other threads:[~2022-07-20 3:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 23:41 [PATCH v4] Add ioctls to get/set the ext4 superblock uuid Jeremy Bongio
2022-07-20 3:18 ` Matthew Wilcox [this message]
2022-07-20 3:30 ` Darrick J. Wong
2022-07-20 14:11 ` Matthew Wilcox
2022-07-20 18:00 ` Theodore Ts'o
2022-07-20 18:27 ` Matthew Wilcox
2022-07-20 18:47 ` Darrick J. Wong
2022-07-20 19:08 ` Matthew Wilcox
2022-07-20 20:11 ` Jeremy Bongio
2022-07-20 20:23 ` Darrick J. Wong
2022-07-20 14:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytd0G0glVWdv+iaD@casper.infradead.org \
--to=willy@infradead.org \
--cc=bongiojp@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).