From: Christoph Hellwig <hch@infradead.org>
To: Jeremy Bongio <bongiojp@gmail.com>
Cc: Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, linux-block@vger.kernel.org,
Jeremy Bongio <jbongio@google.com>
Subject: Re: [RFC PATCH 1/1] Remove buffered failover for ext4 and block fops direct writes.
Date: Wed, 1 May 2024 22:45:06 -0700 [thread overview]
Message-ID: <ZjMoYkUsQnd33mXm@infradead.org> (raw)
In-Reply-To: <20240501231533.3128797-2-bongiojp@gmail.com>
On Wed, May 01, 2024 at 04:15:33PM -0700, Jeremy Bongio wrote:
> From: Jeremy Bongio <jbongio@google.com>
>
> ext4 and block fops would both failover to syncronous, buffered writes if
> the direct IO results in a short write where only a portion of the request
> was completed.
>
> This patch changes the behavior to simply return the number of bytes
> written if the direct write is short.
Please don't combine ext4 and block changes in a single patch. Please
also explain why you want to change things.
AFAIK this is simply the historic behavior of the old direct I/O code
that's been around forever. I think the XFS semantics make a lot more
sense, but people might rely on this one way or another.
next prev parent reply other threads:[~2024-05-02 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 23:15 [RFC PATCH 0/1] Change failover behavior for DIRECT writes in ext4/block fops Jeremy Bongio
2024-05-01 23:15 ` [RFC PATCH 1/1] Remove buffered failover for ext4 and block fops direct writes Jeremy Bongio
2024-05-02 5:45 ` Christoph Hellwig [this message]
2024-05-02 14:01 ` Theodore Ts'o
2024-05-02 14:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjMoYkUsQnd33mXm@infradead.org \
--to=hch@infradead.org \
--cc=bongiojp@gmail.com \
--cc=jbongio@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).