From: Alexey Gladkov <legion@kernel.org>
To: "Dmitry V. Levin" <ldv@strace.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: linux/kd.h: include missing header
Date: Thu, 23 May 2024 11:29:20 +0200 [thread overview]
Message-ID: <Zk8McCtAhKtMTt2n@example.org> (raw)
In-Reply-To: <20240523092310.GA31777@altlinux.org>
On Thu, May 23, 2024 at 12:23:10PM +0300, Dmitry V. Levin wrote:
> Given that linux/kd.h now uses macros defined in linux/ioctl.h,
> do not rely on that header being already included by linux/kd.h users
> and include linux/ioctl.h explicitly.
>
> This bug was found by strace CI.
>
> Fixes: 8c467f330059 ("VT: Use macros to define ioctls")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
Acked-by: Alexey Gladkov <legion@kernel.org>
> ---
> include/uapi/linux/kd.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
> index 8ddb2219a84b..8fcce939ba25 100644
> --- a/include/uapi/linux/kd.h
> +++ b/include/uapi/linux/kd.h
> @@ -3,6 +3,7 @@
> #define _UAPI_LINUX_KD_H
> #include <linux/types.h>
> #include <linux/compiler.h>
> +#include <linux/ioctl.h>
>
> /* 0x4B is 'K', to avoid collision with termios and vt */
> #define KD_IOCTL_BASE 'K'
> --
> ldv
>
--
Rgrds, legion
prev parent reply other threads:[~2024-05-23 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 9:23 [PATCH] uapi: linux/kd.h: include missing header Dmitry V. Levin
2024-05-23 9:29 ` Alexey Gladkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk8McCtAhKtMTt2n@example.org \
--to=legion@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=ldv@strace.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).