From: Devin Bayer <dev@doubly.so>
To: Luke Jones <luke@ljones.dev>, corentin.chary@gmail.com
Cc: "Hans de Goede" <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH 2/2] platform/x86: asus-wmi: support newer fan_boost_mode dev_id
Date: Fri, 21 Jun 2024 09:53:14 +0200 [thread overview]
Message-ID: <a0188274-8420-4d10-857a-b0d680e4a989@doubly.so> (raw)
In-Reply-To: <19cb366a-e6d8-4608-98c9-0fad389363ee@app.fastmail.com>
On 20/06/2024 23.17, Luke Jones wrote:
>
>> #define ASUS_WMI_FNLOCK_BIOS_DISABLED BIT(0)
>> -#define ASUS_WMI_DEVID_CAMERA_LED 0x00060079
>
> Be careful not to introduce extraneous changes.
Yes, will do.
> Thank you for the work on this. But I must point out that the same 0x00110019 method has already been submitted as a patch to work with the existing "throttle_thermal" functionality, which itself is also tied to platoform_profile class support.
>
> See https://lore.kernel.org/platform-driver-x86/20240609144849.2532-1-mohamed.ghanmi@supcom.tn/T/#mcd18e74676084e21d5c15af84bc08d8c6b375fb9
I see that now.
> If you could submit only the first patch instead please?
I'll followup on this topic in the other thread.
~ Dev
prev parent reply other threads:[~2024-06-21 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 8:22 [PATCH 0/2] platform/x86: asus-wmi: support a couple Zenbook 2023 features Devin Bayer
2024-06-20 8:22 ` [PATCH 1/2] platform/x86: asus-wmi: support camera disable LED Devin Bayer
2024-06-20 21:40 ` Luke Jones
2024-06-21 7:50 ` Devin Bayer
2024-06-21 9:25 ` Luke Jones
2024-06-20 8:22 ` [PATCH 2/2] platform/x86: asus-wmi: support newer fan_boost_mode dev_id Devin Bayer
2024-06-20 21:17 ` Luke Jones
2024-06-21 7:53 ` Devin Bayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0188274-8420-4d10-857a-b0d680e4a989@doubly.so \
--to=dev@doubly.so \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).