From: Devin Bayer <dev@doubly.so>
To: Luke Jones <luke@ljones.dev>, corentin.chary@gmail.com
Cc: "Hans de Goede" <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH 1/2] platform/x86: asus-wmi: support camera disable LED
Date: Fri, 21 Jun 2024 09:50:50 +0200 [thread overview]
Message-ID: <a18c8b3a-90b0-47a7-aff6-a289ecddc2c0@doubly.so> (raw)
In-Reply-To: <ede8505f-bcf6-403e-bda2-6848cd4ff4c7@app.fastmail.com>
Thanks for the review, Luke.
On 20/06/2024 23.40, Luke Jones wrote:
>>
>> + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_CAMERA_LED)) {
>> + asus->camera_led.name = "platform::camera";
>
> What do other devices label their camera LED as? The one I could find appears to use `<vendor>::camera`. So maybe `asus::camera` would be better? This also keeps in line with `asus::kbd_backlight`.
I reasoned it would be better to keep the name generic is so out of the
box desktops could toggle the camera and the LED when KEY_CAMERA is
pressed, just like with micmute and mute.
But I'll submit a new version with just this patch and the name change.
~ Dev
next prev parent reply other threads:[~2024-06-21 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 8:22 [PATCH 0/2] platform/x86: asus-wmi: support a couple Zenbook 2023 features Devin Bayer
2024-06-20 8:22 ` [PATCH 1/2] platform/x86: asus-wmi: support camera disable LED Devin Bayer
2024-06-20 21:40 ` Luke Jones
2024-06-21 7:50 ` Devin Bayer [this message]
2024-06-21 9:25 ` Luke Jones
2024-06-20 8:22 ` [PATCH 2/2] platform/x86: asus-wmi: support newer fan_boost_mode dev_id Devin Bayer
2024-06-20 21:17 ` Luke Jones
2024-06-21 7:53 ` Devin Bayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18c8b3a-90b0-47a7-aff6-a289ecddc2c0@doubly.so \
--to=dev@doubly.so \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).