From: Sean Christopherson <seanjc@google.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: John Hubbard <jhubbard@nvidia.com>,
Peter Zijlstra <peterz@infradead.org>,
Shuah Khan <shuah@kernel.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Oliver Sang <oliver.sang@intel.com>,
Christian Brauner <christian@brauner.io>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*
Date: Thu, 8 May 2025 07:04:23 -0700 [thread overview]
Message-ID: <aBy5503w_GuNTu9B@google.com> (raw)
In-Reply-To: <e87bbc68-0403-4d67-ae2d-64065e36a011@linuxfoundation.org>
On Wed, May 07, 2025, Shuah Khan wrote:
> The issues Peter is seeing regarding KHDR_INCLUDES in the following
> tests can be easily fixed by simply changing the test Makefile. These
> aren't framework related.
>
> kvm/Makefile.kvm: -I ../rseq -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES)
...
> You can make the change to remove the reference to KHDR_INCLUDES.
> If don't have the time/bandwidth to do it, I will take care of it.
Please don't remove the KHDR_INCLUDES usage in KVM's selftests, KVM routinely
adds tests for new uAPI. Having to manually install headers is annoying, but
IMO it's the least awful solution we have.
next prev parent reply other threads:[~2025-05-08 14:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:20 [PATCH v3 0/3] introduce PIDFD_SELF* sentinels Lorenzo Stoakes
2024-10-16 10:20 ` [PATCH v3 1/3] pidfd: extend pidfd_get_pid() and de-duplicate pid lookup Lorenzo Stoakes
2024-10-16 10:20 ` [PATCH v3 2/3] pidfd: add PIDFD_SELF_* sentinels to refer to own thread/process Lorenzo Stoakes
2024-10-16 10:20 ` [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* Lorenzo Stoakes
2024-10-16 20:00 ` Shuah Khan
2024-10-16 22:06 ` Lorenzo Stoakes
2024-10-16 22:30 ` Lorenzo Stoakes
2024-10-16 22:38 ` Shuah Khan
2024-10-17 8:08 ` Lorenzo Stoakes
2024-10-17 12:06 ` Lorenzo Stoakes
2024-10-17 17:17 ` John Hubbard
2024-10-17 17:28 ` Lorenzo Stoakes
2024-10-17 17:37 ` John Hubbard
2024-10-17 17:38 ` Lorenzo Stoakes
2024-10-17 19:37 ` Shuah Khan
2024-10-17 19:40 ` Lorenzo Stoakes
2024-10-17 2:14 ` John Hubbard
2024-10-17 7:54 ` Lorenzo Stoakes
2025-05-01 11:42 ` Peter Zijlstra
2025-05-01 12:46 ` Peter Zijlstra
2025-05-01 19:50 ` Sean Christopherson
2025-05-05 13:35 ` Christian Brauner
2025-05-06 9:28 ` Lorenzo Stoakes
2025-05-06 21:18 ` Shuah Khan
2025-05-06 21:34 ` John Hubbard
2025-05-07 20:49 ` Shuah Khan
2024-10-17 2:01 ` The "make headers" requirement, revisited: " John Hubbard
2024-10-17 16:33 ` Shuah Khan
2024-10-17 16:47 ` John Hubbard
2025-05-07 20:50 ` Shuah Khan
2025-05-08 14:04 ` Sean Christopherson [this message]
2025-05-08 15:06 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBy5503w_GuNTu9B@google.com \
--to=seanjc@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=christian@brauner.io \
--cc=jhubbard@nvidia.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=oliver.sang@intel.com \
--cc=pedro.falcato@gmail.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).