From: Tycho Andersen <tycho@tycho.pizza>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrei Vagin <avagin@google.com>, Andrei Vagin <avagin@gmail.com>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
criu@lists.linux.dev, Linux API <linux-api@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: do_change_type(): refuse to operate on unmounted/not ours mounts
Date: Wed, 13 Aug 2025 13:09:27 -0600 [thread overview]
Message-ID: <aJzi506tGJb8CzA3@tycho.pizza> (raw)
In-Reply-To: <20250813185601.GJ222315@ZenIV>
On Wed, Aug 13, 2025 at 07:56:01PM +0100, Al Viro wrote:
> @@ -3347,18 +3360,11 @@ static int do_set_group(struct path *from_path, struct path *to_path)
>
> namespace_lock();
>
> - err = -EINVAL;
> - /* To and From must be mounted */
> - if (!is_mounted(&from->mnt))
> - goto out;
> - if (!is_mounted(&to->mnt))
> - goto out;
> -
> - err = -EPERM;
> - /* We should be allowed to modify mount namespaces of both mounts */
> - if (!ns_capable(from->mnt_ns->user_ns, CAP_SYS_ADMIN))
> + err = may_change_propagation(from);
> + if (err)
> goto out;
> - if (!ns_capable(to->mnt_ns->user_ns, CAP_SYS_ADMIN))
> + err = may_change_propagation(from);
Just driving by, but I guess you mean "to" here.
Tycho
next prev parent reply other threads:[~2025-08-13 19:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANaxB-xXgW1FEj6ydBT2=cudTbP=fX6x8S53zNkWcw1poL=L2A@mail.gmail.com>
[not found] ` <20250724230052.GW2580412@ZenIV>
2025-07-26 17:12 ` do_change_type(): refuse to operate on unmounted/not ours mounts Andrei Vagin
2025-07-26 17:53 ` Al Viro
2025-07-26 21:01 ` Andrei Vagin
2025-07-31 2:40 ` Pavel Tikhomirov
2025-07-31 7:53 ` Christian Brauner
2025-07-31 8:11 ` Pavel Tikhomirov
2025-08-13 18:56 ` Al Viro
2025-08-13 19:09 ` Tycho Andersen [this message]
2025-08-13 19:41 ` Al Viro
2025-08-14 4:08 ` Pavel Tikhomirov
2025-08-14 4:42 ` Al Viro
2025-08-14 5:51 ` [PATCH][RFC][CFT] use uniform permission checks for all mount propagation changes Al Viro
2025-08-14 5:57 ` [RFC][CFT] selftest for permission checks in " Al Viro
2025-08-14 6:37 ` Al Viro
2025-08-14 7:07 ` do_change_type(): refuse to operate on unmounted/not ours mounts Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJzi506tGJb8CzA3@tycho.pizza \
--to=tycho@tycho.pizza \
--cc=avagin@gmail.com \
--cc=avagin@google.com \
--cc=brauner@kernel.org \
--cc=criu@lists.linux.dev \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).