From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Borisov Subject: Re: [RFC PATCH v2 3/5] btrfs: generalize btrfs_lookup_bio_sums_dio() Date: Wed, 16 Oct 2019 12:22:33 +0300 Message-ID: References: <01fdb646d7572f7d0d123937835db5c605e25a5e.1571164762.git.osandov@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <01fdb646d7572f7d0d123937835db5c605e25a5e.1571164762.git.osandov@fb.com> Content-Language: en-US Sender: linux-btrfs-owner@vger.kernel.org To: Omar Sandoval , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: kernel-team@fb.com, Dave Chinner , Jann Horn , linux-api@vger.kernel.org List-Id: linux-api@vger.kernel.org On 15.10.19 г. 21:42 ч., Omar Sandoval wrote: > From: Omar Sandoval > > This isn't actually dio-specific; it just looks up the csums starting at > the given offset instead of using the page index. Rename it to > btrfs_lookup_bio_sums_at_offset() and add the dst parameter. We might > even want to expose __btrfs_lookup_bio_sums() as the public API instead > of having two trivial wrappers, but I'll leave that for another day. IMO exposing btrfs_lookup_bio_sums and adding proper kernel doc for its parameters is the correct way forward. Consider doing this if the general direction of this patchset is accepted and before sending the final revision.