linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Jeff Layton' <jlayton@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
	"linux-security-module@vger.kernel.org" 
	<linux-security-module@vger.kernel.org>,
	Karel Zak <kzak@redhat.com>, "Ian Kent" <raven@themaw.net>,
	David Howells <dhowells@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <christian@brauner.io>,
	"Amir Goldstein" <amir73il@gmail.com>
Subject: RE: [RFC PATCH 2/3] add statmnt(2) syscall
Date: Wed, 20 Sep 2023 09:43:13 +0000	[thread overview]
Message-ID: <ac0f42e8ace2474a941b702fb4fa85a3@AcuMS.aculab.com> (raw)
In-Reply-To: <3183d8b21e78dce2c1d5cbc8a1304f2937110621.camel@kernel.org>

From: Jeff Layton
> Sent: 18 September 2023 15:30
....
> A bit tangential to this discussion, but one thing we could consider is
> adding something like a mnt_change_cookie field that increments on any
> significant changes on the mount: i.e. remounts with new options,
> changes to parentage or propagation, etc.
> 
> That might make it more palatable to do something with separate syscalls
> for the string-based fields. You could do:
> 
> statmnt(...);
> getmntattr(mnt, "mnt.fstype", ...);
> statmnt(...);
> 
> ...and then if the mnt_change_cookie hasn't changed, you know that the
> string option was stable during that window.

That would also help with the problem of the mount options
being changed while processing a page fault on the user buffer.

Of, with a call to just get the cookie, could find that nothing
has changed so there is no point looking again.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


  parent reply	other threads:[~2023-09-20  9:43 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 15:22 [RFC PATCH 0/3] quering mount attributes Miklos Szeredi
2023-09-13 15:22 ` [RFC PATCH 1/3] add unique mount ID Miklos Szeredi
2023-09-14  9:03   ` Christian Brauner
2023-09-14  9:30     ` Miklos Szeredi
2023-09-14  9:36       ` Christian Brauner
2023-09-14  9:43         ` Miklos Szeredi
2023-09-14 10:06           ` Christian Brauner
2023-09-15  1:31           ` Ian Kent
2023-09-13 15:22 ` [RFC PATCH 2/3] add statmnt(2) syscall Miklos Szeredi
2023-09-14  6:11   ` Amir Goldstein
2023-09-15  1:05     ` Ian Kent
2023-09-14  9:27   ` Christian Brauner
2023-09-14 10:13     ` Miklos Szeredi
2023-09-14 15:26       ` Christian Brauner
2023-09-15  8:56         ` Miklos Szeredi
2023-09-18 13:51           ` Christian Brauner
2023-09-18 14:14             ` Miklos Szeredi
2023-09-18 14:24               ` Christian Brauner
2023-09-18 14:32                 ` Miklos Szeredi
2023-09-18 14:40                   ` Christian Brauner
2023-09-18 14:51                     ` Miklos Szeredi
2023-09-18 15:22                       ` Christian Brauner
2023-09-18 15:39                         ` Miklos Szeredi
2023-09-19  0:37                           ` Matthew House
2023-09-19  8:02                             ` Miklos Szeredi
2023-09-19  9:07                               ` Christian Brauner
2023-09-19 10:51                                 ` Miklos Szeredi
2023-09-19 12:41                                   ` Christian Brauner
2023-09-19 12:59                                     ` Miklos Szeredi
2023-09-19 13:18                                       ` Christian Brauner
2023-09-19 21:28                               ` Matthew House
2023-09-20  9:42                                 ` Miklos Szeredi
2023-09-20 13:26                                   ` Matthew House
2023-09-21  7:34                                     ` Miklos Szeredi
2023-09-26 13:48               ` Florian Weimer
2023-09-26 14:06                 ` Miklos Szeredi
2023-09-26 14:19                   ` Florian Weimer
2023-09-26 14:33                     ` Miklos Szeredi
2023-09-26 14:39                       ` Florian Weimer
2023-09-26 14:36                     ` Christian Brauner
2023-09-26 14:13                 ` Christian Brauner
2023-09-18 20:58             ` Andreas Dilger
2023-09-19 12:50               ` Christian Brauner
2023-09-20  0:33                 ` Dave Chinner
2023-09-18 14:29         ` Jeff Layton
2023-09-18 14:35           ` Christian Brauner
2023-09-20  9:43           ` David Laight [this message]
2023-09-14 20:39   ` Paul Moore
2023-09-15  9:10     ` Miklos Szeredi
2023-09-17 18:18   ` Sargun Dhillon
2023-09-17 23:36     ` Ian Kent
2023-09-18 13:05       ` Christian Brauner
2023-09-25 12:57   ` Arnd Bergmann
2023-09-25 13:04     ` Christian Brauner
2023-09-25 13:13       ` Miklos Szeredi
2023-09-25 13:19         ` Christian Brauner
2023-09-25 13:20           ` Miklos Szeredi
2023-09-25 15:46             ` Arnd Bergmann
2023-09-26 10:05               ` Christian Brauner
2023-09-27  8:46             ` Miklos Szeredi
2023-09-13 15:22 ` [RFC PATCH 3/3] add listmnt(2) syscall Miklos Szeredi
2023-09-14  6:00   ` Amir Goldstein
2023-09-14  8:50     ` Miklos Szeredi
2023-09-14 10:01       ` Christian Brauner
2023-09-15  1:00     ` Ian Kent
2023-09-17  0:54   ` Matthew House
2023-09-17 14:32     ` Miklos Szeredi
2023-09-18 13:15       ` Christian Brauner
2023-09-19 16:47         ` Paul Moore
2023-09-28 10:07           ` Miklos Szeredi
2023-10-04 19:22             ` Paul Moore
2023-09-14  6:47 ` [RFC PATCH 0/3] quering mount attributes Amir Goldstein
2023-09-15  1:20   ` Ian Kent
2023-09-15  3:06     ` Amir Goldstein
2023-09-16  2:04       ` Ian Kent
2023-09-16  2:19       ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac0f42e8ace2474a941b702fb4fa85a3@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=christian@brauner.io \
    --cc=dhowells@redhat.com \
    --cc=jlayton@kernel.org \
    --cc=kzak@redhat.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mszeredi@redhat.com \
    --cc=raven@themaw.net \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).