From: Paolo Bonzini <pbonzini@redhat.com>
To: nixiaoming <nixiaoming@huawei.com>, rkrcmar@redhat.com
Cc: kvm@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt/kvm avoids oops by adding parameter checking
Date: Tue, 22 Aug 2017 15:37:15 +0200 [thread overview]
Message-ID: <ad18fd18-e58c-bc70-6660-e05ddbb232a9@redhat.com> (raw)
In-Reply-To: <20170822010909.103060-1-nixiaoming@huawei.com>
On 22/08/2017 03:09, nixiaoming wrote:
> The error parameter passed through the external interface causes the system oops.
> So it is necessary to increase the parameter check for all EXPORT_SYMBOL_GPL
>
> example:
> void kvm_get_kvm(struct kvm *kvm)
> {
> refcount_inc(&kvm->users_count); /*oops if kvm == NULL */
> }
> EXPORT_SYMBOL_GPL(kvm_get_kvm);
>
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
No. It's simply a precondition that kvm != NULL in this case.
Paolo
next prev parent reply other threads:[~2017-08-22 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 1:09 [PATCH] virt/kvm avoids oops by adding parameter checking nixiaoming
2017-08-22 13:37 ` Paolo Bonzini [this message]
2017-09-03 3:36 ` kbuild test robot
2017-09-03 4:00 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad18fd18-e58c-bc70-6660-e05ddbb232a9@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).