From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5337AC05027 for ; Thu, 26 Jan 2023 08:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233955AbjAZIrG (ORCPT ); Thu, 26 Jan 2023 03:47:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbjAZIrF (ORCPT ); Thu, 26 Jan 2023 03:47:05 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77A9C76A3 for ; Thu, 26 Jan 2023 00:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674722784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UJoQG8XqIV2gdZ5V2M7MUTXNJ4+fqx8kSeoZEHtCyE=; b=UWeGjmL6q0Sj4pkM0pHuVYZ8wDN2nuIObNTZUVp+gosFV0gHeo8IkPya9vtrqt4SqHTk0k fOdQjiaLdMAOhlOsW+M0n/VZqL/mGiApf7lLqabvGuC3fNPiWK2J3vfiAN5oVxxBIGWd2s EUn31rvMU3kiL13cwbMHLVqHYin+3DE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-224-h7dw9xW0NE261am9LARntw-1; Thu, 26 Jan 2023 03:46:23 -0500 X-MC-Unique: h7dw9xW0NE261am9LARntw-1 Received: by mail-wm1-f71.google.com with SMTP id fl5-20020a05600c0b8500b003db12112fdeso708643wmb.5 for ; Thu, 26 Jan 2023 00:46:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2UJoQG8XqIV2gdZ5V2M7MUTXNJ4+fqx8kSeoZEHtCyE=; b=YvS0zvOgZUnA4tIXod+aoCRYi3SWzZE2E2i/RHaWF6MV1OVCQExWnNZB0k3LyhsvVR bt/F+OTEWGe9DCuCUwyyunrH6c5TKvSgTVW/my3nRifEMTbv28mWt8OwZlimDFJO2baM 2Uub+7AwIjmmVHaaXalOn3KyY+MfppCyKdjGmzDx39qOgPPw/HxCFCFCImzyiO1d3MZp 9tdeLD61/BD8p8qSjCw0fxArC79mB8Y2dflNb9//nEmeVOGYr6cfLau7oDkk8W0ICFbI xfDHmEyNgygEIRbKwQ4yxGnibik51xr+N6sXBL/yeBRetVytETQ2+Al54xsCLi9YP5G3 JC6A== X-Gm-Message-State: AFqh2kp273BTbsvAk4LFL1Yqxs7XcN5U7yt1CWh60Bv3je7FGUEehpSC fhVaIsyEkwQ0OT088awjpy6llLK81emarheMMLsAtbTEUllHLsd0f0C3MLHrityREQ4JqkMYyNN 8iHaN6qbCxFjJ8h2MhzKd X-Received: by 2002:a05:600c:714:b0:3d9:ed30:79d with SMTP id i20-20020a05600c071400b003d9ed30079dmr34687575wmn.18.1674722781977; Thu, 26 Jan 2023 00:46:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXtafnDCs+MxdtjVDkOlNHLIvv1Gu+xFfV8rFc8O/8mrsHf9iNdy6mNIXFzLYO+oSkffev3lmA== X-Received: by 2002:a05:600c:714:b0:3d9:ed30:79d with SMTP id i20-20020a05600c071400b003d9ed30079dmr34687520wmn.18.1674722781631; Thu, 26 Jan 2023 00:46:21 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id p20-20020a05600c2e9400b003d9862ec435sm824806wmn.20.2023.01.26.00.46.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 00:46:21 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 09:46:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 18/39] mm: Handle faultless write upgrades for shstk Content-Language: en-US To: "Edgecombe, Rick P" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Eranian, Stephane" , "kirill.shutemov@linux.intel.com" , "dave.hansen@linux.intel.com" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "akpm@linux-foundation.org" , "Yang, Weijiang" , "Lutomirski, Andy" , "arnd@arndb.de" , "jamorris@linux.microsoft.com" , "linux-doc@vger.kernel.org" , "bp@alien8.de" , "Schimpe, Christina" , "x86@kernel.org" , "mike.kravetz@oracle.com" , "tglx@linutronix.de" , "andrew.cooper3@citrix.com" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Cc: "Yu, Yu-cheng" References: <20230119212317.8324-1-rick.p.edgecombe@intel.com> <20230119212317.8324-19-rick.p.edgecombe@intel.com> <7f63d13d-7940-afb6-8b25-26fdf3804e00@redhat.com> <50cf64932507ba60639eca28692e7df285bcc0a7.camel@intel.com> <1327c608-1473-af4f-d962-c24f04f3952c@redhat.com> <8c3820ae1448de4baffe7c476b4b5d9ba0a309ff.camel@intel.com> <4d224020-f26f-60a4-c7ab-721a024c7a6d@redhat.com> <899d8f3baaf45b896cf335dec2143cd0969a2d8a.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <899d8f3baaf45b896cf335dec2143cd0969a2d8a.camel@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 26.01.23 01:59, Edgecombe, Rick P wrote: > On Wed, 2023-01-25 at 10:43 -0800, Rick Edgecombe wrote: >> Thanks for your comments and ideas here, I'll give the: >> pte_t pte_mkwrite(struct vm_area_struct *vma, pte_t pte) >> ...solution a try. > > Well, it turns out there are some pte_mkwrite() callers in other arch's > that operate on kernel memory and don't have a VMA. So it needed a new Why not pass in NULL as VMA then and document the semantics? The less similarly named but slightly different functions, the better :) -- Thanks, David / dhildenb