From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rcampbell@nvidia.com, linux-mm@kvack.org,
Waiman Long <longman@redhat.com>,
Linux API <linux-api@vger.kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Florian Weimer <fweimer@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] numa: Change get_mempolicy() to use nr_node_ids instead of MAX_NUMNODES
Date: Thu, 28 Feb 2019 21:43:56 +0100 [thread overview]
Message-ID: <adaf3f9c-ac69-9a0d-962c-a21d6e003fbd@suse.cz> (raw)
In-Reply-To: <20190228111110.564d84f62a1b294ca5b1f9df@linux-foundation.org>
On 2/28/19 8:11 PM, Andrew Morton wrote:
>>> Secondly, 4fb8e5b89bcbbb ("include/linux/nodemask.h: use nr_node_ids
>>> (not MAX_NUMNODES) in __nodemask_pr_numnodes()") introduced a
>>
>> There's no such commit, that sha was probably from linux-next. The patch is
>> still in mmotm [1]. Luckily, I would say. Maybe Linus or some automation could
>> run some script to check for bogus Fixes tags before accepting patches?
>
> Ah, that's a relief.
>
> How about we just drop "include/linux/nodemask.h: use nr_node_ids (not
> MAX_NUMNODES) in __nodemask_pr_numnodes()"
> (https://ozlabs.org/~akpm/mmotm/broken-out/include-linux-nodemaskh-use-nr_node_ids-not-max_numnodes-in-__nodemask_pr_numnodes.patch)?
> It's just a cosmetic thing, really.
Yeah the risk of breaking something is not worth it, IMHO.
prev parent reply other threads:[~2019-02-28 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190211180245.22295-1-rcampbell@nvidia.com>
[not found] ` <20190211112759.a7441b3486ea0b26dec40786@linux-foundation.org>
2019-02-27 18:38 ` [PATCH] numa: Change get_mempolicy() to use nr_node_ids instead of MAX_NUMNODES Vlastimil Babka
2019-02-28 19:11 ` Andrew Morton
2019-02-28 20:43 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaf3f9c-ac69-9a0d-962c-a21d6e003fbd@suse.cz \
--to=vbabka@suse.cz \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=fweimer@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).