From: "Arnd Bergmann" <arnd@arndb.de>
To: "Casey Schaufler" <casey@schaufler-ca.com>,
"Paul Moore" <paul@paul-moore.com>,
linux-security-module@vger.kernel.org
Cc: jmorris@namei.org, "Kees Cook" <keescook@chromium.org>,
john.johansen@canonical.com,
"Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>,
stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, "Mickaël Salaün" <mic@digikod.net>
Subject: Re: [PATCH v6 05/11] LSM: Create lsm_module_list system call
Date: Fri, 03 Mar 2023 19:32:18 +0100 [thread overview]
Message-ID: <ae739199-9e9e-4afe-bb32-be1e6ec28e76@app.fastmail.com> (raw)
In-Reply-To: <20230222200838.8149-6-casey@schaufler-ca.com>
On Wed, Feb 22, 2023, at 21:08, Casey Schaufler wrote:
> @@ -1062,6 +1062,7 @@ asmlinkage long
> sys_set_mempolicy_home_node(unsigned long start, unsigned long l
> asmlinkage long sys_lsm_get_self_attr(struct lsm_ctx *ctx, size_t
> *size,
> __u64 flags);
> asmlinkage long sys_lsm_set_self_attr(struct lsm_ctx *ctx, __u64
> flags);
> +asmlinkage long sys_lsm_module_list(u64 *ids, size_t *size, int flags);
...
> + */
> +SYSCALL_DEFINE3(lsm_module_list,
> + u64 __user *, ids,
> + size_t __user *, size,
> + u64, flags)
> +{
I see that the prototype does not match the definition here,
which really should raise a compiler error, but I suspect that
broke at some point.
Since none of the flags bits are actually used here, can we
please make this a 32-bit field as in the prototype rather
than the 64-bit one in the argument list?
Passing 64-bit arguments through 32-bit registers would make
the calling conventions incompatible with compat mode tasks
on 64-bit kernels.
Arnd
next prev parent reply other threads:[~2023-03-03 18:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230222200838.8149-1-casey.ref@schaufler-ca.com>
2023-02-22 20:08 ` [PATCH v6 00/11] LSM: Three basic syscalls Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 01/11] LSM: Identify modules by more than name Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 02/11] LSM: Maintain a table of LSM attribute data Casey Schaufler
2023-02-25 13:37 ` kernel test robot
2023-02-22 20:08 ` [PATCH v6 03/11] proc: Use lsmids instead of lsm names for attrs Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 04/11] LSM: syscalls for current process attributes Casey Schaufler
2023-02-23 4:57 ` kernel test robot
2023-02-23 8:32 ` kernel test robot
2023-02-23 12:49 ` kernel test robot
2023-03-03 18:41 ` Arnd Bergmann
2023-03-07 11:51 ` Mickaël Salaün
2023-03-09 2:30 ` Casey Schaufler
2023-03-14 22:00 ` Paul Moore
2023-03-07 11:56 ` Mickaël Salaün
2023-03-07 17:04 ` Casey Schaufler
2023-03-07 17:13 ` Casey Schaufler
2023-03-07 14:57 ` Florian Weimer
2023-02-22 20:08 ` [PATCH v6 05/11] LSM: Create lsm_module_list system call Casey Schaufler
2023-03-03 18:32 ` Arnd Bergmann [this message]
2023-03-07 11:33 ` Mickaël Salaün
2023-04-06 16:31 ` Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 06/11] LSM: wireup Linux Security Module syscalls Casey Schaufler
2023-02-23 10:19 ` Geert Uytterhoeven
2023-03-03 18:34 ` Arnd Bergmann
2023-02-22 20:08 ` [PATCH v6 07/11] LSM: Helpers for attribute names and filling an lsm_ctx Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 08/11] Smack: implement setselfattr and getselfattr hooks Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 09/11] AppArmor: Add selfattr hooks Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 10/11] SELinux: " Casey Schaufler
2023-02-22 20:08 ` [PATCH v6 11/11] LSM: selftests for Linux Security Module syscalls Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae739199-9e9e-4afe-bb32-be1e6ec28e76@app.fastmail.com \
--to=arnd@arndb.de \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).