From: Matthew Wilcox <willy@infradead.org>
To: Theodore Tso <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Akilesh Kailash <akailash@google.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org,
Christian Brauner <christian@brauner.io>
Subject: Re: [PATCH v2] f2fs: another way to set large folio by remembering inode number
Date: Thu, 21 May 2026 18:42:03 +0100 [thread overview]
Message-ID: <ag9D6_7dttbDGHZ6@casper.infradead.org> (raw)
In-Reply-To: <20260521155748.GA79343@macsyma-wired.lan>
On Thu, May 21, 2026 at 11:57:48AM -0400, Theodore Tso wrote:
> So let me get this straight. This is a magic xattr interface which is
> not even persisted in the file system, but instead sets a 32-bit
> bitmask in the struct inode which disappears once the inode gets
> flushed from the inode stack. And it uses a generic xattr name,
> "user.fadvise".
>
> There's no way in *hell* any other file system is likely to adopt such
> a broken interface, so why didn't you just use an ioctl to set this
> magic f2fs-specific flag?
I mean, yes, this API is horrendous. But it's just another example of
f2fs thinking it's somehow special and not just enabling large folios
like other filesystems do. This hurts everyone, not just people who use
f2fs.
next prev parent reply other threads:[~2026-05-21 17:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260409134538.3692605-1-jaegeuk@kernel.org>
[not found] ` <adhPZxtbZxgU-37v@google.com>
2026-04-14 8:02 ` [PATCH v2] f2fs: another way to set large folio by remembering inode number Christoph Hellwig
2026-04-15 16:44 ` Jaegeuk Kim
2026-04-15 17:15 ` Matthew Wilcox
2026-04-15 22:02 ` Jaegeuk Kim
2026-04-15 23:49 ` Darrick J. Wong
2026-04-16 1:19 ` Jaegeuk Kim
2026-05-21 8:51 ` Christoph Hellwig
2026-05-21 15:57 ` Theodore Tso
2026-05-21 17:42 ` Matthew Wilcox [this message]
2026-05-22 3:59 ` Jaegeuk Kim
2026-05-22 12:55 ` Matthew Wilcox
2026-05-22 14:04 ` [f2fs-dev] " Jaegeuk Kim
2026-05-22 3:32 ` Jaegeuk Kim
2026-05-22 3:53 ` Eric Biggers
2026-05-22 4:02 ` Jaegeuk Kim
2026-05-22 10:01 ` Christian Brauner
2026-05-22 14:11 ` Theodore Tso
2026-05-22 17:08 ` Jaegeuk Kim
2026-05-22 22:41 ` Theodore Tso
2026-05-22 9:59 ` Christian Brauner
2026-04-15 16:41 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag9D6_7dttbDGHZ6@casper.infradead.org \
--to=willy@infradead.org \
--cc=akailash@google.com \
--cc=christian@brauner.io \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox