From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF50D1F8723; Fri, 22 May 2026 03:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779420762; cv=none; b=Ah+Y/Q40ZhF/g0exSVzKUM3+qLvMW6obM466R5mYZbwxywlTHgIOgy9LNzJeZhp+RqGUWeV1pqOTRn7LAbEETMtnxUqrFCCB1wRxXJyYjwcJia8lFHuV2H+5ehwSAFBPAV19MGmDzulKeEnI4/3L66Us1P5zUnr5JzdQ26cvcH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779420762; c=relaxed/simple; bh=aTe607YLL2D2+izBI4lOWSP0MU1tNfq+EHSoE0D1GOs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=scImTC/Y7PdNH0MFMMFzNCseEjHzVDYUrvotq2nXoh0Re6L0LivLXW7iYjmDaEUrHNcFUBsDfpkI245i3Ktu8wThoghTMNUumfruygj+ZNOHVzl9VRvMROfRtGhSgsqZXqUKsdAGHNlj9HKpB8rw1LwE4OTI/DG58t4hBXGFbW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XU/IlB9S; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XU/IlB9S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 240291F000E9; Fri, 22 May 2026 03:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779420761; bh=CGFAvI18BKBe3vm3c5WorkCHjUcjWwmCPrmYoSAlc2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XU/IlB9SH9nlFWYU/EiIad/OZNWTJfz8uzGq441tNsdlZHlxAhPQwtA2NOjDRpp9S jsCQvoPHpW/b2EqxF4z9HctvBw2zcUUMvy0PL79CW7tF6sSr9KaxQilTtBvSpuNzqm LQb87xxVBr99WUX4SXHuRN9DK8q+KFJ//Sw7qV26y3Fn9lfiqnc2QNNAuAppqwkISa IzKvOiT+uSEDGkJ0H1/ydXDs9FselwOycC80O8y436kSj8vTfb/9oUcRB5YSJcxjNT MqyLv9+oWkNXUQUAOs44eSNwTfA+PX8Cm5Fx7teBgjoWyybo8QhspPJkMRersifqVP doyNr89pmQCpQ== Date: Fri, 22 May 2026 03:32:39 +0000 From: Jaegeuk Kim To: Theodore Tso Cc: Christoph Hellwig , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Akilesh Kailash , Christian Brauner Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number Message-ID: References: <20260409134538.3692605-1-jaegeuk@kernel.org> <20260521155748.GA79343@macsyma-wired.lan> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260521155748.GA79343@macsyma-wired.lan> On 05/21, Theodore Tso wrote: > On Thu, May 21, 2026 at 01:51:08AM -0700, Christoph Hellwig wrote: > > > You haven't sent a proposal. This is a reply to a reply to a reply of a > > > patch. There's no justification for why f2fs is so special that it > > > needs this. What the hell is going on? You know this is not the way to > > > get code merged into Linux. > > > > None of this got properly answers, and this broken interface now landed > > in linux-next. IT is offloading a user.* xattr which is free-form > > user data with semantics that are weird to say it very nicely. > > > > All this was done against the advice in the mailing list discussion. > > So let me get this straight. This is a magic xattr interface which is > not even persisted in the file system, but instead sets a 32-bit > bitmask in the struct inode which disappears once the inode gets > flushed from the inode stack. And it uses a generic xattr name, > "user.fadvise". > > There's no way in *hell* any other file system is likely to adopt such > a broken interface, so why didn't you just use an ioctl to set this > magic f2fs-specific flag? I went this route because Android heavily restricts ioctl() permissions and we needed broader access for this to work within the framework. It’s definitely a pragmatic choice just to get it running in production. If ioctl() is a right way for upstream, I'm happy to change this patch. By the way, I really don't understand why all the messages are so offensive, even without trying to understand the problem or guiding right directions. > > > I think at some point we just need to stop taking f2fs updates likes > > this. > > Well, that's ultiamtely up to Linus. I'll say that if I were Linus > (and I'm glad I'm not :-), and I saw this in a pull request, I'd > reject it out of hand. But whether it's worth making a huge fuss and > asking escalating this mess to Linus, we probably should get a bit > more community consensus before taking such a drastic step. Could I also raise a quick concern regarding the phrasing/wording used in the communications? > > Christian, since you're one of the VFS maintaienrs, what's your > opinion about escalating this to Linus? > > - Ted > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel