From: Richard Patel <ripatel@wii.dev>
To: Florian Weimer <fweimer@redhat.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
David Laight <david.laight.linux@gmail.com>,
Andy Lutomirski <luto@kernel.org>, Kees Cook <kees@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
libc-alpha@sourceware.org, linux-api@vger.kernel.org,
Arjun Shankar <ashankar@redhat.com>
Subject: Re: [PATCH v2 0/5] Usermode Indirect Branch Tracking
Date: Fri, 5 Jun 2026 20:32:40 +0000 [thread overview]
Message-ID: <aiMyaJ8zDl76YOVN@wii.dev> (raw)
In-Reply-To: <lhu1pek4w89.fsf@oldenburg.str.redhat.com>
On Fri, Jun 05, 2026 at 09:34:46PM +0200, Florian Weimer wrote:
> How do you detect that handling a signal is complete and IBT can be
> re-enabled? Or is it re-enabled before entering the userspace signal
> handler?
Hi Florian,
In v1, we backed up the IBT CPU state into the (user-accessible) signal
frame from FRED/XSAVE, then restored it:
https://lore.kernel.org/lkml/20260517183024.16292-4-ripatel@wii.dev/
In v2, when entering the signal handler, the kernel just context switches
to the new user rip, bypassing IBT checks (continues executing if the
signal handler does not begin with endbr).
IBT stays enabled in both designs, just the IBT state is preserved in v1,
and lost in v2.
The same thing happens when doing a sigreturn in v2 (e.g. via trampoline),
again IBT is not enforced. IBT stays enabled when doing a siglongjmp,
though.
Some time in the future, ideally:
- signal handler is *required* to start with endbr (this is easy)
- sigreturn as in my asm example enforces endbr after returning from a
signal handler to a in-progres indirect branc
- libc (sig)longjmp is made IBT-compatible
Btw, I had self-tests for the v1 design, and {signal handle,rt_sigreturn,
siglongjmp} with {success case,violation} works flawlessly with Fedora 44
glibc amd64. With glibc i686 I ran into PLT issues, probably my fault.
It is quite surprised that siglongjmp was working, btw, since the glibc
longjmp code uses 'jmp *reg' (without notrack prefix). I guess you do an
endbr64 at the setjmp side?
> > The main question is whether glibc is happy with this prctl syscall API.
>
> As far as I can tell, the prctl works for glibc. Re-use of an
> arch_prctl constant might have been problematic, but the series is not
> doing that.
Nice :-)
The alternative would have been to bolt on stuff to ARCH_SHSTK, or create
an entirely new arch_prctl. Open to any API.
> Adding the ELF GNU note parsing can be added later, but perhaps not
> cleanly. I'm still a bit worried we might have to rev the markup
> because too many binaries are in circulation that claim compatibility,
> have never been tested, and are actually broken. If the kernel does not
> look at the ELF bits, things a slightly simpler.
Phew, I was hoping you'd say that.
If you want, I can sketch out glibc IBT enabling and test it on Debian
and Fedora, which IIRC already emit compile with -fcf-protection=branch
for all OS packages.
> > There is one notable gap in this patch series, to do with signals:
> >
> > 000a: mov rax, 0x100a
> > 000f: jmp rax
> > *** signal occurs ***
> > *** signal handler runs, does sigreturn ***
> > 100a: nop
> >
> > The above sequence does not crash.
> >
> > With IBT, it should crash at the nop (because an endr64 is expected there).
> > The IBT state (WAIT_FOR_ENDBR in IA32_U_CET MSR) is not backed up to the
> > signal frame though. So, when userland does a sigreturn, the CPU has
> > forgotten that it was doing an indirect branch before the signal.
> > (This specifically only occurs with signal handlers that sigreturn.)
> >
> > This is because IA32_U_CET is part of XSAVE 'supervisor' state, so
> > regular XSAVE/XRSTOR can't access it. Doing a manual backup is tricky.
>
> That's a bit annoying. Is this restricted to signal handlers, or does
> it apply to page faults, too?
Only signal handlers, page faults don't reset IBT.
> > A related problem is that the signal handler routine is not checked for
> > endbr preamble.
>
> That's not necessarily a problem because its address cannot be directly
> overwritten in userspace. Not all indirect branches need to be checked,
> only those that have tweakable targets. In fact, fewer ENDBR64 markers
> are better (although we wouldn't drop the marker from a signal handler
> specifically, of course).
Just one concern I have is that people start relying on signal handlers
not requiring endbr64, and then a future kernel version breaking them once
we enforce it.
Really appreciate your review,
-Richard
prev parent reply other threads:[~2026-06-05 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260605184715.3383415-2-ripatel@wii.dev>
2026-06-05 19:34 ` [PATCH v2 0/5] Usermode Indirect Branch Tracking Florian Weimer
2026-06-05 20:32 ` Richard Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiMyaJ8zDl76YOVN@wii.dev \
--to=ripatel@wii.dev \
--cc=ashankar@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.laight.linux@gmail.com \
--cc=fweimer@redhat.com \
--cc=hpa@zytor.com \
--cc=kees@kernel.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox