From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9C373E009F; Thu, 25 Jun 2026 12:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782389561; cv=none; b=E2DvzvIEpRiFUUkR3J/B4rbeNumagkp1R/nM93d1ivX00i358cK9MMsufGsMm6oCAuZ01wMd1NNCkVOO5Qzjl1WL2Q/h5S3WwAhXjhJ4uB+TL3uDwD2IWCN4M0hMUDiZpAIH73qzjIdtXK/jHYd+F4kN07EE+823We70yyopnp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782389561; c=relaxed/simple; bh=uFEp+qIlUPtG9+DByvkEOZubewNDhx7zt0VqPDAv8gY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kgl10Pg6XKX+Vyu8d0BKMWwHBpMcKJtprV1hXNKfDN7FXxVdvppQLsbLweQOR+vkm4vFg6WGuoa97GOyR6OnEgJut7BJRrq/81PcF2XTwufdrwSWqmPFETqIG9fYU8o119TZ8wgpqV0MMEHaUh45mV3OXzCxz6SYS5rVxQTGKS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=1CyM3fA6; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="1CyM3fA6" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=svkW/aRLfGG744Tq4U8nr/u6yrPBiucq7dNM63t5Tmk=; b=1CyM3fA6L9AiK9520VvlMAjAbK A/PE8z+2ZQH0STTPOdEyxUtRFKhnivNX5wlY84XZpsPLfRN8gl4oG1hVSGPuvwqlsRP/HBYQTITcU ULykzx7o1/ORMS9SCKk3q90PaqBo48bS34jkiBiPEzsCZq7j+j5V7O6ah14/RZHT5GmMYDdw02qDp 6Y+5KrtlMDLkY47GM8zHIWFrS1XnVfse5sSZfhkbUkaSRNk7mL5mH65XMBOKx8cl7Ry054mO652UC NW5Cfjir8XoHouknc86pHuU4wF32wpScpRQcURk9950tXXZ96/KjiTRkYhQtPNacg/qvXYRQcfKIs jtKQmwbA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wciwg-00000009AMQ-2E9H; Thu, 25 Jun 2026 12:12:38 +0000 Date: Thu, 25 Jun 2026 05:12:38 -0700 From: Christoph Hellwig To: Zhang Yi Cc: "Pankaj Raghav (Samsung)" , Christoph Hellwig , Pankaj Raghav , linux-xfs@vger.kernel.org, bfoster@redhat.com, lukas@herbolt.com, "Darrick J . Wong" , dgc@kernel.org, gost.dev@samsung.com, andres@anarazel.de, kundan.kumar@samsung.com, cem@kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v6 3/3] xfs: add support for FALLOC_FL_WRITE_ZEROES Message-ID: References: <20260611114029.176200-4-p.raghav@samsung.com> <557b2e5c-7c65-48de-87a9-6fba21eca99f@huaweicloud.com> <0b7f1a4f-da1c-4297-8099-98d738070ab7@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b7f1a4f-da1c-4297-8099-98d738070ab7@huaweicloud.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Jun 25, 2026 at 07:16:47PM +0800, Zhang Yi wrote: > I've thought about this more and feel that we need to add one more > scenario here: > > 3) If the blocks at the boundaries are in dirty unwritten or in delay > allocated state, it should be handled the same way as scenario 2. > Additionally, before returning, we need to flush these two boundary > blocks that have been partially zeroed, to ensure that after > FALLOC_FL_WRITE_ZEROES, all ranges are in the written state. > > What do you think? Yes. Can you send an xfstest addition the exercises these corner cases?