From: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, "Mickaël Salaün" <mic@digikod.net>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"David Drysdale" <drysdale@google.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric W . Biederman" <ebiederm@xmission.com>,
"James Morris" <james.l.morris@oracle.com>,
"Jann Horn" <jann@thejh.net>, "Jonathan Corbet" <corbet@lwn.net>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Michael Kerrisk" <mtk.manpages@gmail.com>,
"Kees Cook" <keescook@chromium.org>,
"Paul Moore" <paul@paul-moore.com>,
"Sargun Dhillon" <sargun@sargun.me>,
"Serge E . Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and is_valid_subtype() verifier (fwd)
Date: Wed, 29 Mar 2017 17:14:11 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1703291712590.2989@hadrien> (raw)
[-- Attachment #1: Type: text/plain, Size: 2795 bytes --]
Size is unsigned, so not negative.
julia
---------- Forwarded message ----------
Date: Wed, 29 Mar 2017 23:06:01 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and
is_valid_subtype() verifier
In-Reply-To: <20170328234650.19695-2-mic@digikod.net>
TO: "Mickaël Salaün" <mic@digikod.net>
Hi Mickaël,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Micka-l-Sala-n/Landlock-LSM-Toward-unprivileged-sandboxing/20170329-211258
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
>> kernel/bpf/syscall.c:1041:5-9: WARNING: Unsigned expression compared with zero: size < 0
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 07d282aef4f60235407284c0be81d01e352e040b
vim +1041 kernel/bpf/syscall.c
f4324551 Daniel Mack 2016-11-23 1025 return -EINVAL;
f4324551 Daniel Mack 2016-11-23 1026 }
f4324551 Daniel Mack 2016-11-23 1027
7f677633 Alexei Starovoitov 2017-02-10 1028 return ret;
f4324551 Daniel Mack 2016-11-23 1029 }
f4324551 Daniel Mack 2016-11-23 1030 #endif /* CONFIG_CGROUP_BPF */
f4324551 Daniel Mack 2016-11-23 1031
99c55f7d Alexei Starovoitov 2014-09-26 1032 SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr __user *, uattr, unsigned int, size)
99c55f7d Alexei Starovoitov 2014-09-26 1033 {
99c55f7d Alexei Starovoitov 2014-09-26 1034 union bpf_attr attr = {};
99c55f7d Alexei Starovoitov 2014-09-26 1035 int err;
99c55f7d Alexei Starovoitov 2014-09-26 1036
1be7f75d Alexei Starovoitov 2015-10-07 1037 if (!capable(CAP_SYS_ADMIN) && sysctl_unprivileged_bpf_disabled)
99c55f7d Alexei Starovoitov 2014-09-26 1038 return -EPERM;
99c55f7d Alexei Starovoitov 2014-09-26 1039
07d282ae Mickaël Salaün 2017-03-29 1040 size = check_user_buf((void __user *)uattr, size, sizeof(attr));
07d282ae Mickaël Salaün 2017-03-29 @1041 if (size < 0)
07d282ae Mickaël Salaün 2017-03-29 1042 return size;
99c55f7d Alexei Starovoitov 2014-09-26 1043
99c55f7d Alexei Starovoitov 2014-09-26 1044 /* copy attributes from user space, may be less than sizeof(bpf_attr) */
99c55f7d Alexei Starovoitov 2014-09-26 1045 if (copy_from_user(&attr, uattr, size) != 0)
99c55f7d Alexei Starovoitov 2014-09-26 1046 return -EFAULT;
99c55f7d Alexei Starovoitov 2014-09-26 1047
99c55f7d Alexei Starovoitov 2014-09-26 1048 switch (cmd) {
99c55f7d Alexei Starovoitov 2014-09-26 1049 case BPF_MAP_CREATE:
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next reply other threads:[~2017-03-29 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:14 Julia Lawall [this message]
2017-03-31 21:19 ` [PATCH net-next v6 01/11] bpf: Add eBPF program subtype and is_valid_subtype() verifier (fwd) Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703291712590.2989@hadrien \
--to=julia.lawall@lip6.fr \
--cc=acme@kernel.org \
--cc=ast@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=drysdale@google.com \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=jann@thejh.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mic@digikod.net \
--cc=mjg59@srcf.ucam.org \
--cc=mtk.manpages@gmail.com \
--cc=paul@paul-moore.com \
--cc=sargun@sargun.me \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).