From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH for 4.16 08/10] membarrier: x86: Provide core serializing command (v3) Date: Tue, 16 Jan 2018 19:29:33 +0100 (CET) Message-ID: References: <20180115191104.12437-1-mathieu.desnoyers@efficios.com> <20180115191104.12437-9-mathieu.desnoyers@efficios.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180115191104.12437-9-mathieu.desnoyers@efficios.com> Sender: linux-kernel-owner@vger.kernel.org To: Mathieu Desnoyers Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andy Lutomirski , "Paul E . McKenney" , Boqun Feng , Andrew Hunter , Maged Michael , Avi Kivity , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Dave Watson , "H . Peter Anvin" , Andrea Parri , Russell King , Greg Hackmann , Will Deacon , David Sehr Linus Torvalds List-Id: linux-api@vger.kernel.org On Mon, 15 Jan 2018, Mathieu Desnoyers wrote: > There are two places where core serialization is needed by membarrier: > > 1) When returning from the membarrier IPI, > 2) After scheduler updates curr to a thread with a different mm, before > going back to user-space, since the curr->mm is used by membarrier to > check whether it needs to send an IPI to that CPU. This wants to be split into x86 and core changes. Ideally you make the core changes before the previous patch and add the empty inline into linux/processor.h.... Thanks, tglx