From: Pankaj Raghav <pankaj.raghav@linux.dev>
To: Christoph Hellwig <hch@infradead.org>,
Zhang Yi <yi.zhang@huaweicloud.com>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
linux-xfs@vger.kernel.org, bfoster@redhat.com, lukas@herbolt.com,
"Darrick J . Wong" <djwong@kernel.org>,
dgc@kernel.org, gost.dev@samsung.com, andres@anarazel.de,
kundan.kumar@samsung.com, cem@kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v6 3/3] xfs: add support for FALLOC_FL_WRITE_ZEROES
Date: Thu, 25 Jun 2026 14:16:11 +0200 [thread overview]
Message-ID: <b86337f2-5aa5-4905-9610-35fafed2018b@linux.dev> (raw)
In-Reply-To: <aj0bNstaTvy3HOkh@infradead.org>
On 6/25/2026 2:12 PM, Christoph Hellwig wrote:
> On Thu, Jun 25, 2026 at 07:16:47PM +0800, Zhang Yi wrote:
>> I've thought about this more and feel that we need to add one more
>> scenario here:
>>
>> 3) If the blocks at the boundaries are in dirty unwritten or in delay
>> allocated state, it should be handled the same way as scenario 2.
>> Additionally, before returning, we need to flush these two boundary
>> blocks that have been partially zeroed, to ensure that after
>> FALLOC_FL_WRITE_ZEROES, all ranges are in the written state.
>>
>> What do you think?
>
> Yes. Can you send an xfstest addition the exercises these corner
> cases?
>
I have already created one that does a subset of these cases. I will add more
and send it to the list soon!
--
Pankaj
next prev parent reply other threads:[~2026-06-25 12:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260611114029.176200-4-p.raghav@samsung.com>
2026-06-16 13:31 ` [PATCH v6 3/3] xfs: add support for FALLOC_FL_WRITE_ZEROES Christoph Hellwig
2026-06-17 9:44 ` Pankaj Raghav (Samsung)
2026-06-18 3:22 ` Zhang Yi
2026-06-18 8:18 ` Pankaj Raghav (Samsung)
2026-06-18 8:57 ` Christoph Hellwig
2026-06-18 8:59 ` Christoph Hellwig
2026-06-18 10:26 ` Zhang Yi
2026-06-25 11:16 ` Zhang Yi
2026-06-25 12:12 ` Christoph Hellwig
2026-06-25 12:16 ` Pankaj Raghav [this message]
2026-06-25 12:19 ` Christoph Hellwig
2026-06-25 12:29 ` Zhang Yi
2026-06-18 9:00 ` Christoph Hellwig
2026-06-18 9:28 ` Pankaj Raghav (Samsung)
2026-06-18 9:36 ` Christoph Hellwig
2026-06-18 13:26 ` Pankaj Raghav (Samsung)
2026-06-18 13:37 ` Christoph Hellwig
2026-06-18 13:57 ` Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b86337f2-5aa5-4905-9610-35fafed2018b@linux.dev \
--to=pankaj.raghav@linux.dev \
--cc=andres@anarazel.de \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=kundan.kumar@samsung.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
--cc=p.raghav@samsung.com \
--cc=yi.zhang@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox